Repository navigation
refactor(desktop): move remote access out of the app store - #3810
Merged
Merged
Conversation
state/store.ts was over 9,000 lines. Its remote access section (the remote server switch, pairing, the QR challenge, connect requests, revoking a device) and the read clock only it uses move to state/remoteAccess.ts, and their callers import them from there. No behaviour changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
state/store.tswas over 9,000 lines. This moves its remote access section intostate/remoteAccess.ts: the remote server switch, pairing, the QR challenge, connect requests, revoking a device, and the read clock only they use. Callers (RemoteAccessPage,RemoteConnect,ConnectRequests,MachinesPage,MachineSettingsPageand two test files) import from the new module.resetForTestsresets the clock throughresetRemoteStatusReads().No behaviour changes. It is a first, low-risk step: the module only needs
useApp,request,toastanderrorTextfrom the store, so it reads like the otherstate/modules.Changelog
none
Testing
bun run check(typecheck, lint, all unit tests including the remote pairing and store tests).