Repository navigation
fix: use u32 for loanId and preserve cents in repayment XDR - #2193
Open
stevenirewole wants to merge 1 commit into
Open
stevenirewole wants to merge 1 commit into
stevenirewole wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR corrects the backend Soroban test coverage around the loan repayment path so that
loanIdis validated asu32and amounts are not truncated. It accompanies the frontend fix described in #65 by pinning the expected contract argument types in the backend service tests.Related Issue
Changes
🧪 Loan Manager Service Tests
backend/src/services/__tests__/sorobanService.loanManager.test.tsloan_idasu32, matchingLoanManager::repay.Math.floortruncation.Verification Results
Tests for the loan manager service were updated; run them with:
loanIdis encoded asu32for repayment callsMath.floor)u64mismatchCloses #1783