Add DuckLake storage extension with SQL pushdown support - #87
Merged
Merged
Conversation
Mirrors the Iceberg/Unity Catalog extensions: embeds DuckDB, LOADs the ducklake (+httpfs) extension, and ATTACHes 'ducklake:<metadata>' inside the embedded instance. Reuses DuckDBCatalog + AttachedDuckDBDatabase, so information_schema column lookups and the ForeignJoinPushDownOptimizer work with no core changes (default schema 'main', like DuckDB). - DBTYPE DUCKLAKE; 'ducklake:'-prefixed, postgres-style, and file metadata paths pass through; empty path uses the TYPE ducklake secret. - ducklake_data_path / ducklake_read_only options (SET-able, env-seeded), forwarded as DATA_PATH + OVERRIDE_DATA_PATH / READ_ONLY. - Hermetic e2e test (ducklake.test) with checked-in file-backed catalog; rel tables need explicit CREATE REL TABLE ... WITH (storage=...) since DuckLake stores no PK/FK constraints for auto-detection.
The e2e runner executes every test file under extension/, including ducklake.test, but libducklake.lbug_extension was never built because EXTENSION_LIST omitted ducklake. LOAD_DYNAMIC_EXTENSION then failed and both DuckLake cases cascaded (unknown option, no DBTYPE handler).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the Iceberg/Unity Catalog extensions: embeds DuckDB, LOADs the ducklake (+httpfs) extension, and ATTACHes
ducklake:<metadata>inside the embedded instance. Reuses DuckDBCatalog + AttachedDuckDBDatabase, so information_schema column lookups and the ForeignJoinPushDownOptimizer work with no core changes (default schemamain, like DuckDB).ducklake:-prefixed, postgres-style, and file metadata paths pass through; empty path uses the TYPE ducklake secret.ducklake_data_path/ducklake_read_onlyoptions (CALL-settable, env-seeded), forwarded as DATA_PATH + OVERRIDE_DATA_PATH / READ_ONLY.Companion core PR: LadybugDB/ladybug#1002 (wires the submodule + Makefile list + ATTACH hint).
Verified: builds via build/ext, both e2e cases pass, EXPLAIN shows the 3-way join collapsing to a single pushed-down TABLE_FUNCTION_CALL.