Repository navigation
Address review follow-ups on foreign join pushdown (#996) - #1001
Merged
adsharma merged 1 commit intoSep 20, 2026
Merged
Conversation
- Resolve the node-table ID column from the bound catalog entry's primary key instead of assuming it is the first foreign column; fall back to an `id`-named column before ordinal position. - Simplify the src/dst endpoint predicate into an isEndpointColumn helper shared (by convention) with DuckDBCatalog. - Document the all-or-nothing endpoint fallback and the unqualified table-name fallback trade-off; extract quote-stripping helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #996, which merged without these review changes.
id-named column before ordinal position. Without this, Iceberg/Unity Catalog node tables whose PK is not first join on the wrong column.isEndpointColumnhelper shared (by convention) withDuckDBCatalog::createForeignRelTable.No build/test run; clang-format-18 clean.