Conversation
octobocto
force-pushed
the
2026-09-08-spend-unconfirmed
branch
2 times, most recently
from
September 8, 2026 06:53
1c8d967 to
837b07e
Compare
octobocto
force-pushed
the
2026-09-08-spend-unconfirmed
branch
6 times, most recently
from
September 8, 2026 10:04
4672e34 to
fcd38e3
Compare
octobocto
force-pushed
the
2026-09-08-spend-unconfirmed
branch
from
September 27, 2026 15:06
fcd38e3 to
ac69a50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wallet::select_coinsreads the confirmedutxostable only, so a secondcreate_transferfails withNotEnoughFunds, or it takes the coin the first one spends and fails withUtxoDoubleSpent. The wallet now keeps the unconfirmed outputs it may spend, the mempool holds a chain of at most 25, and a block may spend an output that an earlier transaction of the same body made. This is a hard fork: an old node rejects such a block.--spend-zero-conf-changetakes the wallet's own change only, the way Bitcoin Core's-spendzeroconfchangedoes.