Conversation
This was referenced Sep 27, 2026
octobocto
force-pushed
the
sep-27-thunder-wallet-task
branch
2 times, most recently
from
September 27, 2026 14:44
f543534 to
c744ae4
Compare
octobocto
force-pushed
the
sep-27-thunder-wallet-task
branch
from
September 27, 2026 14:59
c744ae4 to
5a855bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A node stopped reporting new coins until a restart:
AppderivesClone, andDrop for Appaborted the shared wallet update task, so the first dropped clone killed it for every other clone. Thecreate_deposit,mine,connect_blockandget_block_templatehandlers each clone the app per request, which is why a node that mines its own blocks still looked correct.Dropnow aborts only whenArc::get_mutgives the last reference, the wayNetTaskHandleandMainchainTaskHandlealready do.