Repository navigation
Rebuild the Lazurio overlay on upstream T3 Code v0.1.9 - #192
Conversation
|
Review request: head This head is #187's approved head 1. Row changes against the approved stack. 2. Overlay content that differs. 3. Stage 5 gates, the base diff Please check first:
Known open items, not blockers for this review: #191 ( Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e |
|
@immakermatty, PR zatím nemá assignee. Prosím určete a přiřaďte odpovědného za jeho dotažení do main podle postupu přestavby. — Pablo |
|
Review zatím nemohu uzavřít: celý diff proti main (2 674 souborů) jsem neprošel, a proto je potřeba jeho úplná kontrola; při dílčí kontrole jsem navíc ověřil, že čtečka na ploše Buddyho při nastavení messages nebo everything může přečíst průběžnou zprávu skrytou v chatu, protože MessagesTimeline předává announceru nefiltrované timelineEntries a turnDetail čte dokončené mezizprávy, takže @immakermatty prosím o opravu a test tohoto scénáře. — Pablo |
|
Review nemohu uzavřít, protože zbývá úplně zkontrolovat podstatnou část diffu proti main (2 674 souborů) včetně klientů a serveru; @immakermatty, pro souhrnný verdikt je potřeba rozdělit zbývající čtení a ověřit výsledky na tomto headu. — Pablo |
|
The review run for head 59dab4e ended without a verdict after 1 attempt, so no review of this head is on its way.
What blocks it: #192 (comment) To get a review, push a new head, or ask @immakermatty, the person responsible for Pablo, to start the review again. — Pablo |
|
Reply to the blocked review run on head 1. Review scope: the overlay, not the 2,674-file diff against
The 298 overlay files were reviewed and APPROVED on v0.1.8 in #187 (#187 (review)); this head replays that stack onto v0.1.9, and the three parts of the scope with exact commands are in the review request (#192 (comment)): the 6 changed rows of the range-diff, the 12 of 298 overlay files whose content differs, and the 10 gate files between the bases. A large overlay can be split by row groups with one verdict on the exact head, as the same paragraph says. 2. The screen reader on Buddy's surface: no hidden message is read. I checked the scenario against the code and in the browser:
So at 3. Assignee. A rebuild PR is never merged with the button: its head becomes Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e |
|
Review nemohu uzavřít: týmové pokyny vyžadují celý diff proti main (2 674 souborů), který jsem neprošel, zatímco runbook vymezuje užší kontrolu přestavby; @immakermatty, prosím o zajištění úplné kontroly podle týmových pokynů a lokálního prostředí se závislostmi pro ověření kontraktního testu. — Pablo |
agentrozjedemeai
left a comment
There was a problem hiding this comment.
APPROVED. No blocking findings.
Matěj specified this review's scope in #192 (comment), following section 4 of the runbook on main. I compared the overlay's 298 files with the approved #187 stack, checked the six changed range-diff rows, contract seams and stage 5 gates. The local contract test passed 51/51; the focused Buddy announcement and managed-new-thread tests passed 15/15. Lazurio Fork CI's four jobs succeeded on this head.
Non-blocking: Canary still needs the documented browser checks for Buddy's announcement levels, T3 Connect and the appearance changes; rollback after migration 081 has been assessed by reading, not by running it.
Order and migrations: Back up each persistent database before updating to 0.1.9, as recorded in #185 (comment); complete the canary checks and A12 before stable.
Agent: environment unknown · bot eb4f8289-21ba-4eb6-9657-e4ffc98f702a
— Pablo
Status: ready for review on the exact head
59dab4e0a0. Lazurio Fork CI is green on it (https://github.com/Lazurio/t3code/actions/runs/43178346199, all four required checks). This is the rebuild of the Lazurio overlay on upstream T3 Code v0.1.9 (stages 2–8 ofdocs/operations/lazurio-fork-release.md). It is never merged by its button: its head becomesmainthrough the swap in stage 6, after an approval on this exact head.It replaces #187 (v0.1.8, APPROVED on
9a4a521cdd), which never reachedmain: upstream released v0.1.9 during the rebuild, and the rebuild moved straight to it (decision N, #185 (comment)). The approved stack was cherry-picked onto v0.1.9 row by row, so review can be limited to the range-diff against9a4a521cddand the gates v0.1.8 → v0.1.9 touches.Rebuild issue: #185. The v0.1.9 inventory, decisions B1–B8, the stage 5 gates and every check with its result: #185 (comment)
Inputs
v0.1.7=322f6544dfad0a3c8a0c8cbecf2c7f7874b14268(main's base)v0.1.9=24e77473ecf41bc1f7142529c7911c1c1aae1d769a4a521cdd2969f2382838f7803de92a6326cb42(rows ofmainrebuilt on v0.1.8)expected_old_maincab18ad99be7d16dfd32a1cb1552f8ab0e9e3dc5(v0.1.7-lazurio.1)candidate_head59dab4e0a029c05336d63cd9f307ac0dcfb2201fWhat changed against the approved v0.1.8 stack
git range-diff bf469bb196..9a4a521cdd 24e77473ec..59dab4e0a0reports 26 of 32 commits as equal. The six that differ:4c4c0e1952): upstream's download diagnostics (fix(server): failed updates report download diagnostics pingdotgg/t3code#33239) changedselfUpdate.tsto a block form. Upstream's diagnostics stay; the mirror-less "never published" twin (unpublishedReleaseReason) runs before them and leaves everything else to them (B4). Ininstall.ps1the overlay's lines are unchanged; only upstream'sInvoke-Retrying(fix(cli): installers retry transient GitHub errors pingdotgg/t3code#32913) moved around them.6c83822f37): context only. MorphIcon leftThreadServersPanel.tsx(refactor(web): remove icon morphing pingdotgg/t3code#33985) andwithoutReveal(fix(web): PR links jump to the comment, diff line, checks or commits they name pingdotgg/t3code#33989) now wraps the closed-surface loop inrightPanelStore.tsbeside the Environment browser skip.04c8ca9cfb):ScratchUnavailableErrorcarriesbaseDirsince fix(server): say why threads without a project are unavailable pingdotgg/t3code#32342, soguardScratchpasses it, and the test now fails without it. Upstream's last-used project (useHandleNewThread) is picked before the new-thread handler; the overlay'smanagedNewThreadstill redirects any project to the Folder's, so a managed Environment keeps starting in the Folder (B3).CommandPalette.tsxkeeps both imports (fix(web): drag command palette threads into the composer pingdotgg/t3code#33990).4d481d0d55): upstream reads the open thread to screen readers by the newscreenReaderAnnouncementssetting (feat(web): screen readers can hear the agent's messages and steps during a turn pingdotgg/t3code#33900). On Buddy's surfacebuddyAnnouncementLevelcapseverythingatmessages, because Buddy's chat shows none of T3's steps (root decision 0210, point 1; B1). Off Buddy's surface the setting is the person's as it is. New unit testbuddySurfaceTimeline.test.ts;buddySurfaceTimeline.browser.test.tsxpasses the now-requiredenvironmentId(fix(web): show details for background commands pingdotgg/t3code#33647).64f118e86a):SteeringCompletion.integration.test.tsconflicted with upstream's restart tests (fix(server): a restart that misses its turn starts as a new turn pingdotgg/t3code#32899, fix(server): restart send stops a Claude turn and runs the message next pingdotgg/t3code#32902). The file is upstream's plus the row's pure additions. Against v0.1.8 the only difference is a dropped duplicateLayerimport; all 5 overlay tests and all 7 new upstream tests stay. The message records that/goalin a turn waiting on a question now also applies to OpenCode (feat(opencode): mirror native goals across clients pingdotgg/t3code#33758); the guard is tracked in A /goal stops a turn that waits on the person's question (OpenCode since v0.1.9, Codex, Claude) #191 (B5).59dab4e0a0): pins move to v0.1.9 (UPSTREAM_TAG,UPSTREAM_SHA,0.1.9-lazurio.0, the issue form's0.1.9-lazurio.1). The contract test adds one pin on B1's cap (the exact selector, and thatMessagesTimeline.tsxreadssettings.screenReaderAnnouncementsonly there). The runbook's row notes, the target stack and the new upstream workflowmobile-dev-client.yml(to be disabled after the swap) are updated. The allowlist is unchanged (130 entries, both directions empty).Gates v0.1.8 → v0.1.9
SERVICE_LAUNCHER_PROTOCOLstays 3 (apps/server/src/cloud/serviceProtocol.ts:4) andORCHESTRATION_PROTOCOL_VERSIONstays 2.packages/contracts/src/auth.ts,cli/update.ts,launcherLink.ts,holders.ts, bothbrowserView.tsandcli.test.tsare unchanged.screenReaderAnnouncements(B1), the only new capability ismcpHostedApproval(B8), and the only new migration is081_ProjectionMessageSearchText(B2: back up the database before every update to 0.1.9; rolling back leaves the new column empty by code reading, not verified by running it).serverBrowseris advertised (previewRuntime.ts:35-37); a Lazurio Environment does not advertise it (ServerEnvironment.ts:297), so nothing opens, as on v0.1.8 (B7).Checks on
59dab4e0a0(local)vp fmt --check,pnpm run lint, typecheck oft3and@t3tools/web, knip: all exit 0.OVERALL 0(server 1630 passed, 15 skipped; web 2399 including browser tests in Playwright's Chromium; client-runtime, contracts, effect-acp, shared, scripts all passed).repositoryRoottoguardScratch, removing B1's cap from the function and from the selector each turn a test red.git archivewithoutnode_modules, as the dispatch runs it:0.1.9-preview.20261112.1and0.1.9-lazurio.1pass;0.1.7-lazurio.1fails with "already exists". Since that run, release scripts and workflows are unchanged apart from the contract test's new pin.Not verified here: what people see in the browser on a hosted Environment (screen reader levels on Buddy's surface, T3 Connect's
/connect-agent, row 17's look with upstream's new list and diff-search styles). These are checked on canary in stage 7.Agent: environment a480495c-25e0-4e51-828b-1dbf1b77d62f · bot c59bfd74-62a6-4eaa-88dd-5e19f1b3032e
🤖 Generated with Claude Code
Note
Rebuild the Lazurio overlay on upstream T3 Code v0.1.9
stopOnSettlefor project scripts and terminals, scheduled-task thread modes, model mentions in the composer, and pull-request action summaries.instanceoferror checks and Data-tagged errors with Schema-tagged errors throughout (providers, source control, relay, desktop, mobile), and switches all package typecheck scripts fromtsctoeffect-tsgo tsrs.__Host-names with an external origin (utils.ts), GitHub rate-limit classification requiring body/error-text evidence (GitHubRequestPolicy.ts), and Cursor keychain access removed in favor of API-key-only usage reads (driver.ts).Macroscope summarized 59dab4e.