Repository navigation
fix(chantier): align the branch with the tree the suite was verified on - #304
Merged
LeadcodeDev merged 1 commit intoSep 22, 2026
Merged
Conversation
The 55 findings were merged one squashed commit at a time. Several of them landed during the first merge attempts, before a defect in the carving mechanism was found and corrected, so they carried a snapshot taken while their agent was still polishing rather than that agent's final state. The gap was real, not cosmetic: 200 lines of regression tests missing from one file, 141 from another, 40 from a third. The branch compiled and its remaining tests passed, which is exactly why this needed comparing against something rather than trusting a green run. This takes every path the audit owns from chantier/audit-2026-09-full, the single commit of the whole remediation tree on which fmt, the full test suite and clippy were run, then re-applies the constant-size chunks_exact replacement to the five files that needed it, since that branch predates the lint fix. The two files still differing from it afterwards differ only by that same lint fix, which they now carry and it did not. Verified on this branch: cargo check --workspace --all-targets, cargo test --workspace, cargo clippy --workspace --all-targets -- -D warnings, and cargo fmt --all --check. Refs #220
LeadcodeDev
added a commit
that referenced
this pull request
Sep 22, 2026
…on (#304) The 55 findings were merged one squashed commit at a time. Several of them landed during the first merge attempts, before a defect in the carving mechanism was found and corrected, so they carried a snapshot taken while their agent was still polishing rather than that agent's final state. The gap was real, not cosmetic: 200 lines of regression tests missing from one file, 141 from another, 40 from a third. The branch compiled and its remaining tests passed, which is exactly why this needed comparing against something rather than trusting a green run. This takes every path the audit owns from chantier/audit-2026-09-full, the single commit of the whole remediation tree on which fmt, the full test suite and clippy were run, then re-applies the constant-size chunks_exact replacement to the five files that needed it, since that branch predates the lint fix. The two files still differing from it afterwards differ only by that same lint fix, which they now carry and it did not. Verified on this branch: cargo check --workspace --all-targets, cargo test --workspace, cargo clippy --workspace --all-targets -- -D warnings, and cargo fmt --all --check. Refs #220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of the 55 findings landed during the first merge attempts, before a defect in the carving mechanism was found, so they carried a snapshot taken while their agent was still polishing rather than that agent's final state.
The gap was real rather than cosmetic: 200 lines of regression tests missing from one file, 141 from another, 40 from a third. The branch still compiled and its remaining tests still passed, which is precisely why this needed comparing against a reference instead of trusting a green run.
This takes every path the audit owns from
chantier/audit-2026-09-full(the single commit of the whole remediation tree, on which fmt, the full suite and clippy were run), then re-applies the constant-sizechunks_exactreplacement to the five files that needed it, since that branch predates #277.Verified here:
cargo check --workspace --all-targets,cargo test --workspace,cargo clippy --workspace --all-targets -- -D warnings,cargo fmt --all --check.Refs #220.