Update Hateoas Provider to Align with STAC Best Practices - #15
Merged
Merged
Conversation
USGS restructured their STAC catalog to group items under a shared directory instead of each item having its own subdirectory. This commit: - Builds item hrefs from the link's basename, not a fixed path segment - Supports both forms of file structure
Collaborator
|
Nice work! I'm going to merge this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2404: HateoasProvider doesn't support STAC best-practices and breaks with shared-folder item layouts
Quick Overview: USGS restructured their STAC catalog to group items under a shared directory instead of each item having its own subdirectory. The upstream Hateoas provider doesn't support that file structure, but STAC's catalog-layout best practices explicitly allow this shared-directory structure.
This PR:
Related Issue / discussion
https://code.usgs.gov/wma/nhgf/pygeoapi/-/merge_requests/159 (internal USGS deployment MR, linked for LimnoTech context): links the staging STAC branch to QA and main to production, to ensure a breakage doesn't happen again.
Additional information
Geopython pygeoapi doesn't have a test file for Hateoas provider (it does for other providers). That should be implemented in the future.