Repository navigation
docs(audit): Eve-2 adversarial audit — 8 verified findings in fix-round code - #614
Merged
Merged
Conversation
…nd code + triage of 166 prior findings Round-2 competitor audit of the SDK, auditing the code added by the round-1 fix waves (run leases, <id>.paused marker, secure-by-default routes, multi-approval pauses, abort handling). Eve-2 findings (all reproduced deterministically on main @ f4c8eb1): - Critical: session-ownership check-then-act race leaks a turn + data across principals (f1-session-squat-toctou) - High: unfenced recordFailure poisons a takeover run's checkpoint; <id>.paused write gap admits a side run beside a paused turn; sub-agent grouped approvals skip edited-args schema validation; abort during tool execution hangs send()/approvals.resolve() - Medium: re-paused checkpoint drops approvalIds; unindexed repeated-id stream deltas fragment into phantom tool calls; isStreamingRequest regex false-positive rewrites JSON to SSE Triage of all 166 round-1 findings against current main: 142 fixed, 15 still-open, 9 changed/partial (audit/eve/TRIAGE.md). Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Second competitor-style (\u0022Eve\u0022) audit of the SDK. Round 1 produced ~166 findings that were all fixed and merged (waves E1\u2013E21 + MAIN-HEALTH rounds). This round audited the fix code itself \u2014 run leases, the
\u003cid\u003e.pausedmarker, secure-by-default routes, multi-approval pauses, abort handling.8 verified findings, each with a deterministic repro (
npx tsx audit/eve2/repro/\u003cfile\u003e):recordFailurewriteslastErroronto a foreign run's checkpoint without lease fencing\u003cid\u003e.pausedmarker lands after the pause checkpoint \u2014 a side run is admitted in the gapsend()/approvals.resolve()approvalIds\u2014 durable state names 1 of N approvalsuniqueToolCallIdsfragments unindexed repeated-id stream deltas into phantom callsisStreamingRequestregex false-positive rewrites a JSON reply into SSEFinding 1 is an authorization-boundary breach \u2014 flagged as security-sensitive.
Also included:
audit/eve/TRIAGE.md\u2014 all 166 round-1 findings re-verified on current main (142 fixed, 15 still-open, 9 changed). EVE-0 (resume divergence) confirmed fixed.Test plan
audit/eve2/README.md)Generated with Devin