Repository navigation
Conversation
…ingdotgg#31146) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…disk but not loaded (pingdotgg#36490)
…ged revalidation (pingdotgg#23775) Signed-off-by: Shaswat Raj <shaswat340@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ell (pingdotgg#33064) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: lyn1dev <lyn1dev@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… local port (pingdotgg#24247) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#23743) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: only21mil <only21mil@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…omposer (pingdotgg#26692) Co-authored-by: nibarAhmed <nibarahmed0@gmail.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…hite (pingdotgg#34569) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#36290) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…hes (pingdotgg#36477) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#33244) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…gg#36504) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Grok 4.7 <noreply@x.ai> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…n launch (pingdotgg#36042) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…g#36250) Co-authored-by: Roger <roger@Rogerflix.local> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#35907) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: SAPHID <saphid@users.noreply.github.com> Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#35617) Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…every chunk (pingdotgg#29422) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#27458) Co-authored-by: maximkes <22573701+maximkes@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…es the refusal (pingdotgg#28360) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…28518) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… status (pingdotgg#29855) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…otgg#29628) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead of running forever (pingdotgg#29208) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…itions (pingdotgg#29612) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… diff (pingdotgg#29629) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…der (pingdotgg#29846) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…oved (pingdotgg#29699) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…es (pingdotgg#29867) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…36785) Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…changes (pingdotgg#36786) Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… 09:00 (pingdotgg#36789) Co-authored-by: Alex Southwell <4596216+saphid@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ingdotgg#36758) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#29802) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#29857) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#29395) Co-authored-by: Julius Marminge <julius0216@outlook.com>
Keep the fix to the on-demand sampling label and leave the status dot as it is on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
…pingdotgg#29785) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…6793) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s load or after a network blip (pingdotgg#28708) Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#28945) Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…mand-sampling Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The dot stayed green while the Native badge beside it reported the monitor unavailable. Use the badge's neutral dot unless the server samples on an interval. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the native monitor is idle or unavailable, Settings → Diagnostics → Resource monitor says "Sampling every 0 ms" next to a green live dot. The server reports
sampleIntervalMs: 0in that state (IDLE_SAMPLE_INTERVAL_MS = 0inapps/server/src/resourceTelemetry/NativeTelemetryClient.ts), which means it samples on request, not every 0 ms. The Diagnostics page's own Interval stat already reads0as "On demand" (DiagnosticsSettings.tsx). Only the resource monitor line took it literally.Change
ResourceTelemetryDiagnostics.logic.tsasformatSamplingStatus. It returns "Sampling on demand" for0; every other interval reads as before.Before / after
Settings → Diagnostics at 1440px. Before on the left, after on the right; light on top, dark below.
Verification
New case in the existing
ResourceTelemetryDiagnostics.logic.test.tsfor 0, 500 and 2000 ms.On
main's logic:With the fix:
vp run check:changed: format, lint, knip, typecheck (2 packages), tests and the react compiler check all pass. I took the screenshots withvp run dev(isolated worktree state, native monitor unavailable) in headless Chrome, swappingmain's files in and out on the same server.Surfaces: only the web/desktop Diagnostics page shows this line. Mobile has no diagnostics view. Not checked: the desktop (Electron) shell, which renders the same component.
Model and harness: Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code