Repository navigation
Domain settings: report a failed removal - #299
Merged
Merged
Conversation
remove() in the domain form ignored the response: a failed DELETE cleared the field, closed the dialog and refreshed, so it looked as if the domain was gone while it was still configured. The response is checked now. On failure the dialog stays open and shows the reason (the API's message, or "Could not remove the domain."), so the owner can retry or cancel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
remove()indomain-form.tsxdidn't look at the response ofDELETE /api/guilds/[guildId]/domain. On a 4xx or 5xx it still cleared the field, closed the confirm dialog and refreshed the page. Nothing said that the domain was still there.Fix
res.ok. On failure throw with the API'serroror the newerrRemovetext.ConfirmDialog'serrorprop, so the owner can retry or cancel. Closing the dialog clears the message.errRemovein all seven languages.Checked
pnpm --filter @msk-forms/web typecheck, eslint and prettier on the changed files.apps/web, so this UI path has no test.