Fix Agent test portability and revocation timing - #887
Open
AnthonyRonning wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Agent import exposed a Windows-only path assumption in the ACP approval test and an unsynchronized timer in the Unix shell-revocation test. Use a native absolute path for the ACP fixture, and synchronize revocation after the shell parent is reaped while its same-group descendant still holds the output pipes open.
The cancellation regression now requires clean output EOF and closure of the descendant's FIFO reader. Its synchronization hook exists only in Unix test builds, is scoped to this test's future, and includes fixture-specific failure cleanup. Application behavior, dependency locks, release configuration, and the absolute-path validation rule are unchanged.
Validation:
descendant kept output pipes open; the original implementation was restored.just cipassed: formatting, all four Clippy feature configurations, warning-denied workspace build, and 755 tests (3 pre-existing ignored tests).Follow-up to #885. Dependency advisory policy remains separate in draft #886. No official Agent release is created or enabled.