Skip to content

virtualize rows in large React Table v8 tables - #8261

Open
YheChen wants to merge 2 commits into
MarkUsProject:masterfrom
YheChen:feat/virtualize-react-tables
Open

YheChen wants to merge 2 commits into
MarkUsProject:masterfrom
YheChen:feat/virtualize-react-tables

Conversation

@YheChen

@YheChen YheChen commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Large React Table v8 tables, including the Students table, mount every row on load. Tables with more than 50 matching rows now use TanStack React Virtual to mount the visible rows and a small buffer. The table measures row heights and keeps row numbering and selection consistent as users scroll.

The JavaScript suite passed all 523 active tests, including a regression test for scrolling a 1,000-row table. A Chrome smoke test mounted 17 rows initially, reached row 1,000, and verified that Select All applied to rows outside the initial view.

Screenshots of your changes (if applicable)

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 41769960110

Coverage increased (+0.005%) to 91.404%

Details

  • Coverage increased (+0.005%) from the base build.
  • Patch coverage: 19 of 19 lines across 1 file are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 54343
Covered Lines: 50746
Line Coverage: 93.38%
Relevant Branches: 2649
Covered Branches: 1347
Branch Coverage: 50.85%
Branches in Coverage %: Yes
Coverage Strength: 129.82 hits per line

💛 - Coveralls

@YheChen YheChen changed the title Virtualize rows in large React Table v8 tables virtualize rows in large React Table v8 tables Nov 4, 2026
@YheChen YheChen changed the title virtualize rows in large React Table v8 tables WIP: virtualize rows in large React Table v8 tables Nov 4, 2026
@YheChen
YheChen requested a review from david-yz-liu November 5, 2026 01:56
@YheChen YheChen changed the title WIP: virtualize rows in large React Table v8 tables virtualize rows in large React Table v8 tables Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants