Skip to content

refactor: migrate exam scan log tables to TanStack v8 - #8262

Open
AbhirveM wants to merge 1 commit into
MarkUsProject:masterfrom
AbhirveM:refactor-exam-scan-log-tables
Open

AbhirveM wants to merge 1 commit into
MarkUsProject:masterfrom
AbhirveM:refactor-exam-scan-log-tables

Conversation

@AbhirveM

@AbhirveM AbhirveM commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Migrates ExamScanLogTable, ExamScanErrorsTable, and ExamScanGroupsTable from react-table v6 to the shared TanStack v8 table. Keeps the grouped headers, date sorting, expanded details, counts, and download and fix links.

Updates the shared table to render one row of filters for grouped columns. Filename and error/fixed count columns now have accessors, so their existing sorting and filtering controls use the displayed values.

Screenshots of your changes (if applicable)

Checked the Upload Scans page for the seeded midterm before and after the migration, including both expanded tables. The existing column widths and child-table limits are preserved.

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality) X
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
📖 Documentation update (change that updates documentation)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • [N/A] I have updated the project documentation, if applicable.
    • This is required for new features.
  • [N/A] If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have updated the project Changelog (this is required for all changes).
  • I have verified that the pre-commit.ci checks have passed.
  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

Non-OK log responses return an empty array, preserving the old empty-state behavior and avoiding a v8 render error.

Local verification:

  • 18 scan-log tests and 23 shared-table tests passed.
  • Full Jest suite: 52 suites passed, 548 tests passed, 28 skipped.
  • Production webpack build and applicable pre-commit hooks passed.
  • Browser checks covered the same JSON response, six seeded logs, eight filters, expanded tables, links, and the unsuccessful-response empty state.

@AbhirveM
AbhirveM force-pushed the refactor-exam-scan-log-tables branch 2 times, most recently from 38a9b4e to e738c93 Compare November 5, 2026 17:36
@coveralls

coveralls commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 42093317533

Coverage increased (+0.03%) to 91.431%

Details

  • Coverage increased (+0.03%) from the base build.
  • Patch coverage: 17 of 17 lines across 2 files are fully covered (100%).
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 54363
Covered Lines: 50770
Line Coverage: 93.39%
Relevant Branches: 2633
Covered Branches: 1342
Branch Coverage: 50.97%
Branches in Coverage %: Yes
Coverage Strength: 130.89 hits per line

💛 - Coveralls

@AbhirveM
AbhirveM force-pushed the refactor-exam-scan-log-tables branch from e738c93 to 1a19db4 Compare November 5, 2026 17:53
@AbhirveM
AbhirveM requested a review from david-yz-liu November 5, 2026 18:07
@AbhirveM
AbhirveM force-pushed the refactor-exam-scan-log-tables branch from 1a19db4 to daef928 Compare November 5, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants