fix(impl-review): retry the staging download before the render check - #11697
Merged
Conversation
…empty directory The step swallowed a lost `gsutil cp` (`2>/dev/null || true`), the render check right after it then failed on nothing, and because that failure set no ai-review-failed label, no watchdog case picked the PR up — it waited for a manual re-dispatch (#11360 on 2026-09-05, #11678 on 2026-09-09; staging was complete both times). The download now tries three times with a short backoff, stops as soon as both theme renders are on disk, and keeps gsutil's stderr in a warning per failed attempt: a transfer blip heals in the same run, a genuinely empty staging folder still fails loudly at the render check. The babysit skill gets the gotcha (how to tell the two apart, the one-shot re-dispatch). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LfPAdJKa4JWzvsEUQZUuhs
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LfPAdJKa4JWzvsEUQZUuhs
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The retry is bounded, preserves loud failure for missing renders, and includes operational documentation and a changelog entry.
Pull request overview
This PR makes impl-review resilient to transient staging-download failures and documents the recovery procedure.
Changes:
- Retries GCS image downloads three times with linear backoff and visible warnings.
- Preserves the existing render-existence check for genuinely missing images.
- Documents diagnosis and one-shot re-dispatch guidance.
- Adds the required changelog fragment.
File summaries
| File | Description |
|---|---|
.github/workflows/impl-review.yml |
Adds bounded retries and transfer-error reporting. |
.claude/skills/babysit-pipeline/SKILL.md |
Documents diagnosis and recovery for lost downloads. |
changelog.d/impl-review-staging-download-retry.md |
Records the workflow reliability fix. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gsutil cp(2>/dev/null || true); "Verify both theme renders exist" then failed on an empty directory, and since that failure sets noai-review-failedlabel, no watchdog case matched — the PR waited for a manual re-dispatch. Seen twice with staging complete both times: feat(ggplot2): implement histogram-2d #11360 (2026-09-05 03:56 UTC) and feat(chartjs): implement sparkline-basic #11678 (2026-09-09 18:14 UTC).gsutil's stderr as a warning per failed attempt. A transfer blip heals in the same run; a genuinely empty staging folder still fails loudly at the unchanged render check.babysit-pipelineskill gets the gotcha: how to tell a lost download from a missing render, and the one-shot re-dispatch.Plan
N/A
Test plan
runblock passesbash -nuv run python -m tools.changelog check --base origin/mainpassesstaging download incomplete (attempt 1/3)warning still proceeds to the reviewKnown gap:
.github/workflows/changes have no local verification loop; only real review runs exercise the retry.🤖 Generated with Claude Code
https://claude.ai/code/session_01LfPAdJKa4JWzvsEUQZUuhs