Skip to content

fix(server): leave the console idle window to the client (#27890) #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
MattRiddell wants to merge 1 commit into
base: t3code/todo-27890-base-v016
Choose a base branch
from
Draft

fix(server): leave the console idle window to the client (#27890) #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/server/src/orchestration-v2/freshProviderContext.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,12 +155,13 @@ it.effect.each(["none", "background", "turn", "metadata"] as const)(
bootstrap: "Role; complete handoff; lessons pointer.",
},
};
// The idle policy is the client's: a just-completed, unchanged snapshot is accepted.
assert.equal(
typeof prepareFreshProviderThread(before, command, now),
"string",
"NO: less than 30 minutes",
"object",
"server must not re-impose a thread-updatedAt idle window",
);
yield* TestClock.adjust("31 minutes");
yield* TestClock.adjust("1 minute");
const later = yield* DateTime.now;
const refuse = (records: typeof before, cmd = command) =>
assert.equal(typeof prepareFreshProviderThread(records, cmd, later), "string");
Expand Down
8 changes: 2 additions & 6 deletions apps/server/src/orchestration-v2/freshProviderContext.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ export function preserveFreshContext(

// Refuse before emitting anything. The command's timestamp is a compare-and-swap
// against the saved handoff's snapshot, including input queued since that snapshot.
// The idle window is the client's: automated turns bump updatedAt, so only the
// client can measure time since the human's last message.
export function prepareFreshProviderThread(
records: ProjectionRecords<
"providerThreads" | "runs" | "providerTurns" | "runtimeRequests" | "subagents" | "turnItems"
Expand Down Expand Up @@ -57,12 +59,6 @@ export function prepareFreshProviderThread(
) {
return "Thread changed since the handoff snapshot.";
}
if (
DateTime.toEpochMillis(now) - DateTime.toEpochMillis(records.thread.updatedAt) <
30 * 60_000
) {
return "Thread has not been idle for 30 minutes.";
}
if (!seed.bootstrap.trim() || new TextEncoder().encode(seed.bootstrap).length >= 5_000) {
return "Bootstrap must contain fewer than 5000 UTF-8 bytes.";
}
Expand Down
Loading