Repository navigation
Prototype one profile-run interface for local and Submitit execution - #44
Merged
Merged
Conversation
florian6973
marked this pull request as ready for review
November 3, 2026 13:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
runsubcommand to generated algorithm CLIs. Authors editconfigs/runs/run.yaml, which inherits the coremeds_runHydra schema, then use the same configuration for dry-run, local subprocess execution or dependent Submitit SLURM jobs. The existing per-step commands and shell launcher remain available for comparison and MEDS-DEV compatibility.Install with
uv sync --extra orchestration --extra test, then inspect with<algorithm> run --dry-run. Selectexecution=localorexecution=slurm; resource overrides and artifact reuse are documented. The running guide embeds the canonical core guide rather than copying the shared schema/specification. Release preflight now checks the optional orchestration pin too.Depends on McDermottHealthAI/meds-algorithm#12, pinned at 69c994d5921521132b60a528aab86a2b1641d05a. Keep both as prototype drafts for design review; merge core first if accepted. No existing model repositories are migrated.
Validation: 86 template tests passed, including a real generated supervised algorithm running all three stages through the new local coordinator, expected probabilities and manifest configuration. All six generated profile configs inherit the shared schema. Ruff, strict MkDocs, wheel/sdist builds, strict Twine and installed-generator smoke checks passed. Publication remains blocked by the intentional Git dependency pin.
No real SLURM jobs were submitted. Core exercises Submitit's local executor and tests scheduler dependency/resource/cancellation behavior using a fake scheduler. The prototype uses Hydra composition and direct Submitit submission, with no Hydra multirun, multi-node or checkpoint/resume support yet.