Repository navigation
Conversation
Lists the compose project's containers in an aligned NAME/IMAGE/STATUS/PORTS table, showing only running containers unless -a/--all is passed. Containers are matched primarily by the com.docker.compose.project/service labels stamped since Mcrich23#126 (reliable across naming modes), falling back to the candidate container names for containers created before the labels existed. Resolves the project through the shared ComposeProjectOptions (Mcrich23#138) and fails fast on unknown service names with the noSuchService contract Mcrich23#139 established for up.
Owner
|
Sorry for the slow response! I wasn't able to work on open source for most of the summer, but I'm catching up now. This is a useful addition. One issue: the name fallback can include a container whose labels identify it as belonging to another project. Can you limit that fallback to containers without project labels? Please add coverage for project filtering, service filtering, and stopped containers. |
A container labeled for a different project could be included when its name collided with one of our candidate names (e.g. project demo + service web-x produce the candidate demo-web-x, which is also the name project demo-web gives its service x). Labels are now authoritative whenever present; the candidate-name fallback applies only to containers without compose labels (created before Mcrich23#126 stamped them). Extracts the selection into ComposePs.select, generic over the container representation, with unit coverage for project filtering, service filtering, the unlabeled fallback, and stopped-container visibility with and without --all.
Contributor
Author
|
I added the fallback to limit to those without compose labels. Also added tests for project filtering, service filtering, and stopped containers. I also noticed up/down's pre-start/stop cleanup has the same issue in regards to labels. We can address that in a future PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lists the compose project's containers in an aligned NAME/IMAGE/STATUS/PORTS table, showing only running containers unless -a/--all is passed. Containers are matched primarily by the com.docker.compose.project/service labels stamped since #126 (reliable across naming modes), falling back to the candidate container names for containers created before the labels existed.
Resolves the project through the shared ComposeProjectOptions (#138) and fails fast on unknown service names with the noSuchService contract #139 established for up.