Skip to content

feat: the Theming eXIP's task work on feature/mips Theming_eXIP EXO-91408 - #686

Open
Jihed525 wants to merge 3 commits into
feature/mipsfrom
backport/theming-exip-to-mips
Open

Jihed525 wants to merge 3 commits into
feature/mipsfrom
backport/theming-exip-to-mips

Conversation

@Jihed525

@Jihed525 Jihed525 commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

What

the Theming eXIP's task work on feature/mips, from the Tribe board Validation – Theming (project 8412): every task its stories cover that has a commit in this repository, picked from feature/ai-contribution in its order. Tasks: EXO-91408, EXO-91474, EXO-91383.

Picks

3 commits, git cherry-pick -x, in the order of feature/ai-contribution, picked from the commits on its current history, none of them already on feature/mips (checked by git cherry). The third column compares the pick's patch-id with its source's: = equal, resolved a conflict resolved inside the pick (listed below).

FB commit Pick Patch Subject
e07cffcad 220c27906 = fix: the task drawer's actions menu takes the drawers and popups background set in Branding EXO-91408 (#673)
70c60cfeb 4ca6e1dd1 = fix: the Tasks app shows the application background set in Branding, colour and image EXO-91474 (#674)
2a9ff0e5d 863057771 = fix: the project picker's dropdown takes the drawers and popups background set in Branding EXO-91383 (#672)

Testing

Built before a clean rebase onto the current feature/mips (every pick = in git range-diff), head 863057771: mvn -B clean install: 260 tests, 0 failures, BUILD SUCCESS.

Classification: N3: theme rules only (LESS and Vue templates, one portlet CSS class list), following the backgrounds an administrator sets in Branding; no REST, DAO, schema or ACL surface touched.

Knowledge: pending — EXO-91408

🤖 Generated with Claude Code

@Jihed525
Jihed525 requested a review from azayati October 23, 2026 16:32
@github-actions github-actions Bot added the partialCIBuild Perform Partial CI Build label Oct 23, 2026
srenault-meeds and others added 3 commits October 24, 2026 18:17
…colour and image EXO-91474 (#674)

**Symptom**: with a background set for applications in Branding, the
rows of the Tasks list, and of a project's List view, stayed light grey
instead of showing it, and a background image set for applications
showed nowhere in the Tasks app.

**Cause**: the rows were painted with `@tableBackgroundAccent`
(`tasks.less`), a fixed grey that no Branding key drives. The
`TasksManagement` portlet opts out of the frame's background colour
(`no-layout-background-color`), and its two cards, the tab bar and the
tab content (`TasksManagement.vue`), paint
`application-background-color`, opaque by default, over the image that
the portlet frame (`PORTLET-FRAGMENT`) still painted.

**Fix**:
- the rows are transparent and keep their border, so they show the
application background;
- both cards carry `application-background-image` beside
`application-background-color`, and the portlet's `layout-css-class`
gains `no-layout-background-image`, so the frame paints neither and the
gap between the cards shows the page for the image as for the colour.
The image is painted per card, fitted to each card's box.

No automated test: CSS and template classes only (`frontend-vue.md`, no
JS unit test). Checked on a running 7.3.x `feature/ai-contribution`
server: the rows show the Branding application colour; the Branding
application image shows on the tab bar and on the content card, and
through the rows, on the Tasks tab and on a project's List view.

Knowledge: pending — EXO-91474

This change is classified N3 at `b47b02feb`: no REST/DAO/schema/ACL
surface touched (`classification.md` §3).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 70c60cf)
…round set in Branding EXO-91383 (#672)

Symptom: with a Drawers & Popup background set in Branding and Theme,
the
suggestions list of the project picker of a task event, in the
engagement center's rule form, stays white, with dark grey suggestions.

Cause: the suggestions menu is detached to the page's root application
container and keeps Vuetify's white surface. The picker's content-class
attribute lands on its input, not on the menu: Vuetify 2 takes the menu
content class only from menu-props, and the string form of menu-props
carries flags only.

Fix: menu-props takes its object form, keeping the closeOnClick and
closeOnContentClick flags, and adds the content classes layout-drawer,
which paints the Drawers & Popup colour on the menu, and
application-menu,
which lets the suggestions take the drawer text colour, size, weight and
style instead of the fixed dark grey, the page text size and the normal
weight and style the platform gives menu items, as Meeds-io/social#6233
does for exo-identity-suggester. The string's "maxHeight = 100" entry
was
read as an unknown flag and set no height, so the menu keeps its default
height.

Not covered: a Drawers & Popup background image is hidden by the list's
solid drawer colour.

Knowledge: Meeds-io/eng-standards#440

This change is classified N2 (at 97bf5ab: a shared component of the
addon's common module, rendering only, no REST/DAO/schema/ACL surface) —
its approver must be an Archi/Dev who knows it is N2, not an approval on
AI review alone.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 2a9ff0e)
@Jihed525
Jihed525 force-pushed the backport/theming-exip-to-mips branch from f4d4148 to 8630577 Compare October 24, 2026 17:19
@Jihed525

Copy link
Copy Markdown
Contributor Author

Re-picked from the current feature/ai-contribution — head f4d4148dd → 863057771

The picks named commits of the branch's history before it was rewritten. Each is now picked (-x) from its patch-equal commit on the current feature/ai-contribution; base unchanged, tree at the new head identical to f4d4148dd's. Old → new:

  • 56933ebac → 220c27906
  • 1afb07cf3 → 4ca6e1dd1
  • f4d4148dd → 863057771

@Jihed525
Jihed525 marked this pull request as ready for review October 24, 2026 17:20
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

partialCIBuild Perform Partial CI Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants