Feat: subscription delegation - #10130
Open
tuna1207 wants to merge 29 commits into
Open
Conversation
…ial period handling
…etadata into SubscriptionDelegationService
tanguyenvn
reviewed
Sep 10, 2026
|
|
||
| ### Changed | ||
|
|
||
| - Accept `'subscription-payment'` as a CHOMP intent / delegation metadata type alongside `'cash-deposit'` and `'cash-withdrawal'`. ([#10130](https://github.com/MetaMask/core/pull/10130)) |
Contributor
There was a problem hiding this comment.
we should rename the intent and delegation type according to https://consensyssoftware.atlassian.net/jira/software/c/projects/CHOMP/boards/6409/backlog?issueParent=389761&selectedIssue=CHOMP-37
| const ChompIntentTypeStruct = enums([ | ||
| 'cash-deposit', | ||
| 'cash-withdrawal', | ||
| 'subscription-payment', |
| export type ChompIntentType = | ||
| | 'cash-deposit' | ||
| | 'cash-withdrawal' | ||
| | 'subscription-payment'; |
Contributor
There was a problem hiding this comment.
same as above.
Note that when we support premium vault, we may need add more intent and delegations: cash-deposit-premium, cash-withdrawal-premium
| InvalidDecimals = 'Subscription delegation decimals must be a non-negative integer', | ||
| LossyAmountScale = 'Subscription delegation amount cannot be scaled to token decimals without remainder', | ||
| UnsupportedRecurringInterval = 'Unsupported subscription recurring interval', | ||
| UnsupportedProduct = 'Subscription delegation is only supported for Money Account Plus', |
Contributor
There was a problem hiding this comment.
will we show this error message to end users? We may use MM Orange? Is it possible to have translations instead?
| /** | ||
| * Storage / CHOMP metadata type for subscription-payment delegations. | ||
| */ | ||
| export const SUBSCRIPTION_PAYMENT_DELEGATION_TYPE = 'subscription-payment'; |
Contributor
There was a problem hiding this comment.
may need to rename to cash-subscription
… for alpha demos/tests
tuna1207
marked this pull request as ready for review
September 10, 2026 09:37
tuna1207
temporarily deployed
to
default-branch
September 10, 2026 09:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…Web Crypto API support
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 24e683a. Configure here.
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Money Account Plus crypto subscribe needs a cash-subscription delegation (periodic ERC-20 transfer caveats), not the Shield-style ERC-20 approval path. That workflow was split across clients and backend services with no single Core orchestrator.
This PR adds a stateless
SubscriptionDelegationServicethat owns setup end-to-end and returns adelegationHashforSubscriptionController.startSubscriptionWithCrypto. The controller does not depend on this service; clients callSubscriptionDelegationService:prepareDelegationfirst, then start the subscription with the hash.prepareDelegationflowmoneyAccountVaultConfig(remote feature flags), the delegate from pricingdelegateAddress, and Delegation Framework v1.3.0 enforcers from@metamask/delegation-deployments.checkBalance(unitAmount × minBillingCyclesForBalance).unitAmount/unitDecimals/ token decimals). Offset period-transferstartDatebytrialPeriodDaysonly when the trial is selected.{ delegationHash, disposition: 'created' | 'reused' }.Caveats currently include
ValueLte(0)andERC20TokenPeriodTransfer.RedeemerEnforceris omitted pending CHOMP guidance.Only
MONEY_ACCOUNT_PLUSis supported; Shield continues to use ERC-20 approval.Alpha testing note
This PR does not change
@metamask/chomp-api-service(avoids CHOMP-team CODEOWNERS for alpha).CASH_SUBSCRIPTION_DELEGATION_TYPE('cash-subscription') is defined locally insubscription-controllerfor AUS metadata.Alpha hosts must pass
skipChompInteractions: trueonprepareDelegationso CHOMP verify/intent registration is skipped. AUS persist and local hash computation still run.Production CHOMP intent support for
'cash-subscription'will land in a follow-up that updates@metamask/chomp-api-service. Until then, the default CHOMP-enabled path (skipChompInteractionsunset/false) is dormant and unsupported.Package split
@metamask/subscription-controllerSubscriptionDelegationService, helpers (amount,caveats,fingerprint), messenger actionsprepareDelegation/checkMoneyAccountBalance, localCASH_SUBSCRIPTION_DELEGATION_TYPE, andskipChompInteractionsfor alpha.@metamask/walletDelegationController:signDelegation, Money Account balance, pricing, andRemoteFeatureFlagController:getState.Hosts must register
AuthenticatedUserStorageService,ChompApiService,DelegationController,MoneyAccountBalanceService, andSubscriptionControlleron the root messenger before callingprepareDelegation.RemoteFeatureFlagControlleris already initialized by the default wallet factory. For alpha, still registerChompApiServicefor messenger typing even though it is not called whenskipChompInteractions: true.References
Checklist
Note
Medium Risk
New orchestration around delegation signing, subscription pricing, and user-stored permissions affects the Money Account Plus payment path; mitigated by optional balance gating, reuse rules, and an alpha CHOMP bypass flag.
Overview
Adds a stateless
SubscriptionDelegationServiceso Money Account Plus crypto subscribe can obtain a cash-subscription delegation hash beforestartSubscriptionWithCrypto, without folding that workflow intoSubscriptionController.prepareDelegationresolves chain (feature-flag vault config), pricing token/delegate, and Delegation Framework v1.3.0 enforcers; buildsValueLte(0)+ periodic ERC-20 transfer caveats (trial-awarestartDate); reuses matching Authenticated User Storage delegations via a semantic fingerprint; otherwise signs viaDelegationController, persists to AUS, and optionally verifies/registers CHOMP intents. Returns{ delegationHash, disposition: 'created' | 'reused' }.checkMoneyAccountBalancecompares convertible mUSD againstunitAmount × minBillingCyclesForBalance. Alpha callers must passskipChompInteractions: trueuntil CHOMP accepts'cash-subscription'intent metadata; exportsCASH_SUBSCRIPTION_DELEGATION_TYPElocally. Only Money Account Plus is supported.@metamask/walletregisters the service in default initialization and delegates the required messenger actions. The package gains new dependencies (delegation, CHOMP, AUS, balance services) plus a Jest environment shim for Web Crypto used in salt generation.Reviewed by Cursor Bugbot for commit 060c308. Bugbot is set up for automated code reviews on this repo. Configure here.