Repository navigation
[EMBED-591] tkey stack upgrade 2026 Q4 - #319
lionellbriones wants to merge 7 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
…rus.js. Co-authored-by: Cursor <cursoragent@cursor.com>
Lerna and torus-scripts 8 cannot emit the existing dist layout or typecheck under the new TypeScript and Oxlint presets. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Caution MetaMask internal reviewing guidelines:
Ignoring alerts on:
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…kflows. Co-authored-by: Cursor <cursoragent@cursor.com>
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 | ||
|
|
||
| - name: Setup Node.js ${{ env.NODE_VERSION }} | ||
| uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 | ||
| with: | ||
| node-version: ${{ env.NODE_VERSION }} | ||
| cache: "npm" | ||
|
|
||
| - name: Install npm 12 | ||
| run: npm install --global npm@12.2.0 | ||
|
|
||
| - name: Install Node.js dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Run Build | ||
| run: npm run build && npm exec -- playwright install --with-deps | ||
|
|
||
| - name: Browser tests mocked | ||
| run: npm run browser-tests:local-mocked | ||
|
|
||
| - name: Browser tests production | ||
| run: npm run browser-tests:local-prod |
| this.shares[ss.polynomialID][ss.share.shareIndex.toString(16)] = ss; | ||
| const sharesForPoly = this.shares[ss.polynomialID]; | ||
| if (!sharesForPoly) throw CoreError.fromCode(1307); | ||
| sharesForPoly[ss.share.shareIndex.toString(16)] = ss; |
| if (!sharesForPolynomial) { | ||
| throw CoreError.default("there is no matching polyID"); | ||
| } | ||
| sharesForPolynomial[publicShare.shareIndex.toString(16)] = publicShare; |
| const index = descriptions.indexOf(oldDescription); | ||
| if (index > -1) { | ||
| currentSD[shareIndex][index] = newDescription; | ||
| descriptions[index] = newDescription; |
…de the 3-day window. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
@SocketSecurity ignore npm/eslint-plugin-tsdoc@0.5.4 |
Motivation and Context
Modernize the tkey monorepo to the 2026 Q4 stack policy: Node, npm, LavaMoat, TypeScript, Oxlint/Oxfmt, Vite+ library builds, and Changesets.
This is a breaking change for published packages. Engines are Node >=24.22.0 and npm >=12.
typesisdist/lib.cjs/index.d.ts. The unused@babel/runtimepeer dependency and the UMD build are gone.Release-adoption gates still have no newer major:
@toruslabs/customauthstays^22.3.3(EMBED-590)@toruslabs/torus.jsstays^17.2.3(EMBED-588)Majors adopted on this branch:
@toruslabs/fetch-node-details17@toruslabs/metadata-helpers9@toruslabs/eccrypto8@toruslabs/http-helpers10@toruslabs/constants17typescript7,@toruslabs/config5,@toruslabs/torus-scripts9.0.1@types/node26vite-plus1.5.1, which pinsvitestand@vitest/browser-playwrightat 5.1.0Jira Link
Description
Each published package now uses:
main:dist/lib.cjs/index.jsmodule,unpkg, andjsdelivr:dist/lib.esm/index.jstypes:dist/lib.cjs/index.d.tsThere is no
exportsmap and no UMD file. A packed@tkey/common-typestarball loadsShareStoreandbigIntReplacerthrough bothrequireandimport.@tkey/chrome-storageresolves the same two entry files; loading it in Node then throws fromwebextension-polyfill, which only runs inside an extension.CI is
validateon pull requests andmasterfor Node 24.22.0 and 26, plus a manualrelease-prworkflow that opens the release pull request and does not publish.security-code-scannerruns on pull requests, pushes tomaster, a weekly cron, and manual dispatch. No second CodeQL workflow was added. KICS, Trivy, AWS credentials, and a Wiz sensor do not apply: this repository has no backend, container, or deploy. The token cannot read or change the repository setting that lets Actions open pull requests, or the CodeQL default setup (HTTP 403).npm auditon this branch reports 15 findings (8 low, 7 moderate). The critical and high findings were updated in range. Still open:deepmerge4.3.1 (GHSA-gcqx-w48m-w2h4) is the latest 4.x and is still affected. The vulnerable copy is nested under CustomAuth 22 and torus.js 17. The audit fix would downgrade CustomAuth to 18.1.0.minimatchbelow 11.0.1 (GHSA-g3hv-75wg-m249) is required at^10.2by ESLint and the Oxlint preset'seslint-plugin-tsdoc. Forcing 11 would cross that major. This is lint tooling.Dependabot on the default branch still reports 143 findings until this branch merges. Those alerts were not dismissed.
Nothing has been published.
release-packagesstays manual onmasterafter the release pull request merges.How has this been tested?
@tkey/defaultpassed 55 tests and skipped 4. Eleven seed-phrase tests fail locally becauseTEST_RPC_TARGETis unset. A public Cloudflare endpoint returned RPC internal errors, so those tests still need the GitHub secret.web-storagemocked Chrome browser tests: 12 passed.chrome-storagehas no test files. Its packed entry was loaded in Node only.test-production, theTKEY_FULL=1suite, and non-mocked OneKey tests. They needTEST_RPC_TARGETand the live metadata service.requireand import for@tkey/common-types.tkey/backward-compatibility-testsrepository.Screenshots (if appropriate)
No UI changes.
Types of changes
Checklist