Repository navigation
chore(marketplace): remove Blabsy and Pictique - #1204
Conversation
…Blabsy and Pictique
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 19e02a3f98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const dynamicApps = livePlatforms.filter( | ||
| (p) => !staticIds.has(p.id.toLowerCase()) && !staticNames.has(p.name.toLowerCase()), | ||
| ); |
There was a problem hiding this comment.
When AaaS contains an active profile whose ID or name is blabsy or pictique, removing those entries from apps.json also removes them from staticIds/staticNames, so this filter now admits them as dynamic apps. They consequently remain visible in the catalogue (and the dynamic lookup in app-detail.tsx still serves their detail routes), defeating the intended removal in any environment with such a published or stale profile. Filter the retired identifiers from the live feed or suppress them server-side.
Useful? React with 👍 / 👎.
| const other = categoryLabels.get("other"); | ||
| categoryLabels.delete("other"); | ||
| const categories = ["All Apps", ...Array.from(categoryLabels.values()), ...(other ? [other] : [])]; |
There was a problem hiding this comment.
If a user selects a static category before /api/platforms resolves and a matching live profile then overrides the last app in that category with a different category, this newly derived list removes the selected button while selectedCategory retains its old value. The grid then incorrectly shows zero apps with no selected category control until the user manually chooses All Apps; the same problem can occur after a React Query refetch. Reconcile the selection with the regenerated category list, falling back to All Apps when it disappears.
Useful? React with 👍 / 👎.
| const mergedStatic = staticApps.map((a) => { | ||
| const live = liveByKey.get(a.id.toLowerCase()) ?? liveByKey.get(a.name.toLowerCase()); | ||
| return live?.category ? { ...a, category: live.category } : a; |
There was a problem hiding this comment.
When a live profile changes the category of a static app, this merge makes the home card and filters use the live category, but app-detail.tsx still resolves the same app as staticApp ?? dynamicApp and therefore displays the old static category. Clicking such a card produces contradictory category metadata between the catalogue and its detail page; merge the live category into the static app there as well.
Useful? React with 👍 / 👎.
1 participant
Removes Blabsy and Pictique from the marketplace (static catalogue entries, detail copy and logo assets).
Also derives the category filters from all listed platforms (static and AaaS) instead of a hardcoded list, deduped case-insensitively with "Other" last; a live platform's declared category overrides the static one.