Notebot: replace out of range note rounding with transposing - #6668
Merged
Big-Iron-Cheems merged 2 commits intoSep 21, 2026
Merged
Conversation
Collaborator
|
Transposes out-of-range notes by ±12 semitones until they fit the 0–24 range, preserving their pitch class instead of clamping them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Instead of rounding, transposes notes that are not playable. This makes them actually sound somewhat good!
Related issues
None
How Has This Been Tested?
CCBlueX test server, with NBS files that have out of range notes.
Drop OOR notes:
2026-09-16.22-21-47.mp4
Round OOR notes:
2026-09-16.22-22-38.mp4
Transpose OOR notes:
2026-09-16.22-23-15.mp4
Checklist: