Skip to content

feat(property-detail): add error boundary for property detail - #1288

Merged
nanaf6203-bit merged 2 commits into
MettaChain:mainfrom
Kandexa:feat/issue-1190-add-error-boundary
Oct 15, 2026
Merged

nanaf6203-bit merged 2 commits into
MettaChain:mainfrom
Kandexa:feat/issue-1190-add-error-boundary

Conversation

@Kandexa

@Kandexa Kandexa commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds an error boundary to the PropertyDetail component so a failure while rendering the detail view degrades into a retryable fallback panel instead of taking down the whole property route.

Problem

PropertyDetailServer rendered the image gallery, investment cards, feature grid, external links and mortgage calculator from a single component tree with no boundary around it. An exception thrown while rendering any of those sections propagated to the route level and replaced the entire detail page with the framework error screen, hiding every other section that had rendered correctly.

Changes Made

  • Added the use client directive and imported ErrorBoundary from src/components/ui/SimpleErrorBoundary.tsx in src/components/PropertyDetailServer.tsx.
  • Renamed the existing view to a private PropertyDetailServerInner.
  • Re-exported PropertyDetailServer as a thin wrapper that renders the inner view inside ErrorBoundary.

Implementation Details

The boundary is placed above the component rather than around its returned JSX so errors raised while computing derived values - location, token availability, price and metrics - are caught as well. The use client directive is required because an error boundary is a client-side construct; without it the class component could not be instantiated and errors thrown by this view would bypass the boundary entirely. The export name, props interface and rendered markup are unchanged.

Closes #1190

Closes #1189

Closes #1188

Closes #1187

@drips-wave

drips-wave Bot commented Oct 15, 2026

Copy link
Copy Markdown

@Kandexa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit
nanaf6203-bit merged commit 68c0142 into MettaChain:main Oct 15, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants