Repository navigation
feat(property-detail): add error boundary for property detail - #1288
Merged
nanaf6203-bit merged 2 commits intoOct 15, 2026
Merged
Conversation
|
@Kandexa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an error boundary to the PropertyDetail component so a failure while rendering the detail view degrades into a retryable fallback panel instead of taking down the whole property route.
Problem
PropertyDetailServer rendered the image gallery, investment cards, feature grid, external links and mortgage calculator from a single component tree with no boundary around it. An exception thrown while rendering any of those sections propagated to the route level and replaced the entire detail page with the framework error screen, hiding every other section that had rendered correctly.
Changes Made
Implementation Details
The boundary is placed above the component rather than around its returned JSX so errors raised while computing derived values - location, token availability, price and metrics - are caught as well. The use client directive is required because an error boundary is a client-side construct; without it the class component could not be instantiated and errors thrown by this view would bypass the boundary entirely. The export name, props interface and rendered markup are unchanged.
Closes #1190
Closes #1189
Closes #1188
Closes #1187