Skip to content

fix(release): retain sidebar dividers with upstream label truncation - #22

Merged
Microck merged 1 commit into
personal-updatesfrom
fix/personal-sidebar-divider-4353
Nov 8, 2026
Merged

Microck merged 1 commit into
personal-updatesfrom
fix/personal-sidebar-divider-4353

Conversation

@Microck

@Microck Microck commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Problem

Official nightly v0.1.8-nightly.20261108.4353 adds truncation to collapsible section labels. The carried sidebar-divider patch still expects the earlier label markup, so preparation fails with a cherry-pick conflict in run 42453374827.

Change

Refresh the PR pingdotgg#26403 pin to e876258faa9c0b3f2e04ef17df74bf1414b969a1. The carried change keeps the divider visible beside section counts while retaining upstream's min-w-0 truncate label, panel spacing, tones, accessibility attributes and chevron behavior. All other personal patches, including the owner's latest assistant-progress folding, remain in the manifest.

Composed source: fix/carried-sidebar-divider-4353.

Scope and approval

This is standing owner-authorized maintenance of the existing personal release pipeline: resolve recoverable conflicts personally, preserve personal patches, validate, review, merge safely and release. It repairs an existing capability and reproducible preparation failure without expanding product scope. It claims no triage exemption and changes no workflow, approval gate, credentials, account permissions or billing.

Verification

A fresh replay of the updated manifest onto official nightly 4353 completes without conflicts or an automated resolver and matches composed source tree 26f3a7906228d612f37494864ba59349926886c1. The release compatibility normalizers leave the composed source unchanged. The manifest check:changed passes format, lint, knip, scripts typecheck and all 12 tests. The composed-source check passes dependency patch installation, format, lint, both knip passes, GraphQL generation, all 61 selected regression files (1,297 tests; 3 existing quarantines unchanged), and all 41 selected React compiler checks. All 39 non-marketing package typechecks pass. Astro separately passes 26 files with zero diagnostics using a temporary configuration directory; the aggregate typecheck remains blocked by Astro telemetry trying to create /home/agent/.config/astro, and is not claimed to pass. The required T3 Browser-panel preview tools are absent, so integrated before/after screenshots are not claimed. Existing automated browser regressions, review, CI and release publication gates remain required.

Model and harness: GPT-6 in Codex.

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Thread transfer impact

⚠️ The latest CI run did not produce a thread transfer result for fc3d0b6.

This comment will update automatically after the next completed run.

@Microck
Microck marked this pull request as ready for review November 8, 2026 09:02
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The personal release script now references commit e876258faa9c0b3f2e04ef17df74bf1414b969a1 for the carried fix for PR 26403, replacing the previous commit reference.

Changes: Personal release commit reference

Layer / File(s) Summary
Update carried fix reference
scripts/personal-release.ts
The carried fix for PR 26403 now references commit e876258faa9c0b3f2e04ef17df74bf1414b969a1 instead of 0a0f9e069605a862fb4db486e7a81a916b1b3691.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Merge Risk: Minimal · up to fc3d0

No actionable merge-blocking defect was identified. CI and release publication gates still need to pass.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: retaining sidebar dividers alongside upstream label truncation. The raw summary describes a one-line update of the pinned commit for the carried PR 26403 fix in script…
Description check Passed The description follows the template sections (Problem, Change, Scope and approval, Verification) and fills each one with specific content. Problem: it describes the nightly release that adds label tr…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: retaining sidebar dividers alongside upstream label truncation. The raw summary describes a one-line update of the pinned commit for the carried PR 26403 fix in scripts/personal-release.ts. The title describes the intent of that carried fix, and the objectives confirm it. The title follows conventional commit form, is specific, and is under 72 characters. The title does not mention the commit pin update, but the template asks for a plain-language title about the fix, so this is acceptable.

Full details: Description check

Explanation

The description follows the template sections (Problem, Change, Scope and approval, Verification) and fills each one with specific content. Problem: it describes the nightly release that adds label truncation and the cherry-pick conflict in run 42453374827. Change: it names the pinned commit and the preserved upstream behavior. Scope and approval: it states owner-authorized maintenance and that no triage exemption is claimed. Verification: it lists replay results, check and test counts, the Astro workaround, and the untested browser screenshots. It also names the model and harness, as the template requests. The author does not link a triaged issue or maintainer approval in the Scope section, and the author states that no exemption is claimed. The template requires explicit approval for scope, so that gap is material. The description is mostly complete, so it passes, but the author should attach the issue or approval comment or explain why this qualifies as an exemption. Because the change is a pin refresh for a reproducible release failure, the owner's standing authorization may satisfy the requirement. The Problem section is also a bit long for the template's 'a sentence or two' guidance, but it is not a blocking issue. The UI screenshot gap is disclosed, so it does not fail the check.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 9192841 and fc3d0b6.

Files selected for processing: 1

  • scripts/personal-release.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Microck commented Nov 8, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Please review final head fc3d0b6 and the linked carried change e876258. Verify that the divider remains visible beside counts and upstream label truncation, panel spacing, tones and accessibility are preserved. The complete manifest replays cleanly onto nightly 4353; source regressions, compiler checks and separate package typechecks pass as recorded in Verification. Review only: do not apply changes, enable autofix or change billing. Respect included-review rate limits; do not use paid overage. All CI and release publication gates remain required.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 8, 2026
@Microck
Microck merged commit 61fde8e into personal-updates Nov 8, 2026
46 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant