Skip to content

fix(release): retain model mentions across upstream composer changes - #25

Merged
Microck merged 1 commit into
personal-updatesfrom
fix/personal-model-mentions-4433
Nov 9, 2026
Merged

Microck merged 1 commit into
personal-updatesfrom
fix/personal-model-mentions-4433

Conversation

@Microck

@Microck Microck commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Problem

The latest official nightly 4433 adds upstream model-mention inputs to the composer menu. Replaying the personal OMP ^model patch conflicts at that call, withholding the personal release.

Change

Rebase the OMP model-mention patch onto nightly 4433, retaining both upstream's modelMentions inputs and the OMP patch's selected provider model/instance inputs. Update that one manifest hash. Preserve the existing behavior and regression assertions for both paths.

Scope and approval

Authorized personal-fork maintenance. All other personal patches and required gates remain intact. Official stable v0.1.8 and nightly 4433 point to identical upstream source. A clean full-manifest replay reproduces source tree 5aa9ecbfecfd603d71ba6e11535f91fd95206a05.

Verification

  • Automation check:changed passed: formatting, lint, both knip checks, scripts typecheck and release tests.
  • Explicit release web, mobile and client-runtime typechecks passed.
  • Composed-source check:changed: dependency/unused-patch install, format, lint, both knip checks, GraphQL, 62 test files (1,333 tests passed; three existing skips), and React Compiler checks passed.
  • The aggregate typecheck command failed on Astro trying to create the sandbox-inaccessible /home/agent/.config/astro, interrupting other tasks. All 40 non-marketing package typechecks subsequently passed with explicit package filters. Astro passed separately for all 37 files with telemetry disabled and a writable temporary config directory; no check was weakened.
  • This compatibility repair introduces no new UI behavior. No real-client or user-machine installation is claimed.

Model: GPT-6.1; harness: Codex cloud.

@Microck
Microck marked this pull request as ready for review November 9, 2026 23:09

Microck commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

Please review exact head f1ab82b2114fa10d956dab178b15c336158e8fa1 and rebased carried patch 397eadf0840a622d366490826beb103b93660f67. It preserves both upstream model-mention inputs and the personal OMP inputs at the composer-menu call. The PR description records clean full-manifest replay, explicit release typechecks, 1,333 selected tests, and separately recovered Astro sandbox checks.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The personal release script now points PR 22972 to commit 397eadf0840a622d366490826beb103b93660f67 instead of the previous commit.

Changes: Personal release tracking

Layer / File(s) Summary
Update tracked commit
scripts/personal-release.ts
The commit tracked for PR 22972 changes to 397eadf0840a622d366490826beb103b93660f67.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested labels: size:XS

Merge Risk: Minimal · up to f1ab8

The patch preserves both model-mention paths. No merge-blocking risk was identified; real-client installation remains unverified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly describes the main change: retaining model mentions through upstream composer changes.
Description check Passed The description covers the problem, change, scope, and verification in detail. The scope section does not link a triaged issue or maintainer approval, but the description is otherwise substantially co…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description covers the problem, change, scope, and verification in detail. The scope section does not link a triaged issue or maintainer approval, but the description is otherwise substantially complete.

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 05b4194 and f1ab82b.

Files selected for processing: 1

  • scripts/personal-release.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@github-actions github-actions Bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Nov 9, 2026
@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@Microck
Microck merged commit 0f0c8bf into personal-updates Nov 9, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant