Repository navigation
Document the date contact property type of MillionSend v0.22.0 - #22
Merged
Merged
Conversation
- The javadoc of ContactProperty, ContactPropertyValue and
CreateContactPropertyOptions lists date next to string and number, says
what reads as a date, and that a date value comes back as a String.
- The README says the same under Contact properties, gains a v0.22.0 row
in the server versions table (the date type and the before, after,
in_last_days and not_in_last_days segment ops), and lists date among
the MillionSend extensions.
- ParityTest decodes a {"type":"date"} property value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MillionSend v0.22.0 adds a third contact property type,
date, next tostringandnumber(a MillionSend extension). The SDK already carries it:typeis a plainStringonContactProperty,ContactPropertyValueandCreateContactPropertyOptions, and a date value decodes as aString. This brings the docs in line; no behavior change.ContactProperty.getType(),ContactPropertyValue.getType()/getValue()andCreateContactPropertyOptions.Builder.type()/fallbackValue()listsdateand says what reads as one: an ISO 8601 date (midnight UTC), an ISO 8601 date-time (UTC when it names no zone), or Unix time in seconds or milliseconds from 2000 to 2100; anything else is422 validation_error.ContactPropertyValuecarries aStringfor a date; the server versions table gains a v0.22.0 row with the date type and thebefore,after,in_last_daysandnot_in_last_dayssegment ops;datejoins the MillionSend extensions list.ParityTestdecodes a{"type":"date","value":"2026-01-08"}property value.Docs only: no version bump, nothing to tag.
🤖 Generated with Claude Code