Skip to content

Fix Base Metals sconce compatibility and metal toughness - #144

Merged
SkyBlade1978 merged 5 commits into
MinecraftModDevelopmentMods:master-1.10from
SkyBlade1978:fix/1.10-basemetals-legacy-sconce-textures
Sep 30, 2026
Merged

SkyBlade1978 merged 5 commits into
MinecraftModDevelopmentMods:master-1.10from
SkyBlade1978:fix/1.10-basemetals-legacy-sconce-textures

Conversation

@SkyBlade1978

@SkyBlade1978 SkyBlade1978 commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

  • Offer each Base Metals sconce material only when the installed Base Metals jar includes its block texture. This avoids untextured Antimony, Bismuth, and Pewter variants in the older 2.4.0.11 build.
  • Scale blast resistance and mining hardness by metal, and preserve the selected metal when a sconce is mined or picked. An Adamantine sconce no longer drops as iron.
  • Use Base Metals' exact Cold-Iron and Star-Steel nugget names so their sconce recipes register. Other metal recipe names remain unchanged.
  • Preserve all 16 upholstery colours when either padded bench form is mined. The colour tile entity stays available until Forge creates the drop; bench joining logic is unchanged.

Verification

  • Full clean/check/build/Javadoc, catalog, resources, metadata, namespace, repository hygiene, artifact, checksum, and Eclipse gates passed locally.
  • Packaged Forge server probes passed with Base Metals 2.4.0.11 and 2.5.0-beta4.238 plus their matching OreSpawn builds. All available sconce metals have one recipe (19 and 22 respectively); Adamantine placement, mining, pick-block, and single correct drop also passed.
  • A packaged Forge 1.10.2 server probe reproduced the original red-drop bug before the fix, then verified spawned item metadata and Color NBT for all 16 colours on both padded bench forms. It also verified purple drops from the base and another part of wooden beds, canopy beds, wingback chairs, and thrones.
  • Unit tests cover legacy and current texture layouts, metal hardness/resistance, and the exact Cold-Iron and Star-Steel Ore Dictionary names.

@SkyBlade1978 SkyBlade1978 changed the title Fix Base Metals sconce textures on older 1.10 builds Fix Base Metals sconce compatibility and metal toughness Sep 29, 2026
@SkyBlade1978
SkyBlade1978 merged commit fce2de3 into MinecraftModDevelopmentMods:master-1.10 Sep 30, 2026
5 checks passed
@SkyBlade1978
SkyBlade1978 deleted the fix/1.10-basemetals-legacy-sconce-textures branch October 1, 2026 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant