Repository navigation
GEOPY-3082: Crash converting OMF block model - #222
Merged
Merged
Conversation
domfournier
marked this pull request as ready for review
September 29, 2026 15:49
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The mutable geoh5py branch has already advanced beyond the revision recorded in the committed lock files.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates geoh5py for the OMF block-model conversion fix and adjusts imports for its revised API.
Changes:
- Points geoh5py at the GEOPY-3082 work.
- Updates
Entityimports. - Regenerates Python 3.12–3.14 lock files.
| File | Description |
|---|---|
pyproject.toml |
Changes the geoh5py revision. |
geoapps_utils/utils/reference.py |
Updates the Entity import. |
geoapps_utils/utils/iterables.py |
Updates the Entity import. |
py-3.12.conda-lock.yml |
Refreshes the 3.12 combined lock. |
py-3.13.conda-lock.yml |
Refreshes the 3.13 combined lock. |
py-3.14.conda-lock.yml |
Refreshes the 3.14 combined lock. |
environments/py-3.12-linux-64.conda.lock.yml |
Refreshes the 3.12 Linux runtime lock. |
environments/py-3.12-linux-64-dev.conda.lock.yml |
Refreshes the 3.12 Linux development lock. |
environments/py-3.12-win-64.conda.lock.yml |
Refreshes the 3.12 Windows runtime lock. |
environments/py-3.12-win-64-dev.conda.lock.yml |
Refreshes the 3.12 Windows development lock. |
environments/py-3.13-linux-64.conda.lock.yml |
Refreshes the 3.13 Linux runtime lock. |
environments/py-3.13-linux-64-dev.conda.lock.yml |
Refreshes the 3.13 Linux development lock. |
environments/py-3.13-win-64.conda.lock.yml |
Refreshes the 3.13 Windows runtime lock. |
environments/py-3.13-win-64-dev.conda.lock.yml |
Refreshes the 3.13 Windows development lock. |
environments/py-3.14-linux-64.conda.lock.yml |
Refreshes the 3.14 Linux runtime lock. |
environments/py-3.14-linux-64-dev.conda.lock.yml |
Refreshes the 3.14 Linux development lock. |
environments/py-3.14-win-64.conda.lock.yml |
Refreshes the 3.14 Windows runtime lock. |
environments/py-3.14-win-64-dev.conda.lock.yml |
Refreshes the 3.14 Windows development lock. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| #---------------------------------------- | ||
| # geoh5py = {version = ">=0.14.0a, 0.14.*", source = "pypi", allow-prereleases = true} | ||
| geoh5py = {git = "https://github.com/MiraGeoscience/geoh5py.git", rev = "develop"} | ||
| geoh5py = {git = "https://github.com/MiraGeoscience/geoh5py.git", rev = "GEOPY-3082"} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #222 +/- ##
===========================================
+ Coverage 86.13% 86.44% +0.30%
===========================================
Files 18 18
Lines 974 974
Branches 128 128
===========================================
+ Hits 839 842 +3
+ Misses 99 97 -2
+ Partials 36 35 -1
🚀 New features to boost your workflow:
|
Contributor
|
need to refresh lock after depends on MiraGeoscience/geoh5py#986 is merged |
sebhmg
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3082 - Crash converting OMF block model
depends on MiraGeoscience/geoh5py#986