Skip to content

GEOPY-2972: define version, icon, and documentation to the plate sweep option class - #223

Merged
benk-mira merged 2 commits into
developfrom
GEOPY-2972
Oct 1, 2026
Merged

benk-mira merged 2 commits into
developfrom
GEOPY-2972

Conversation

@domfournier

@domfournier domfournier commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

GEOPY-2972 - define version, icon, and documentation to the plate sweep option class

Copilot AI balanced review requested due to automatic review settings October 1, 2026 13:54
@github-actions github-actions Bot changed the title GEOPY-2972 GEOPY-2972: define version, icon, and documentation to the plate sweep option class Oct 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The implementation broadens the base API beyond the parameter-sweep scope stated by the PR.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Adds UI metadata intended for parameter-sweep options.

Changes:

  • Adds version, icon, and documentation defaults to the shared Options model.
File Description
geoapps_utils/​base.py Adds UI metadata fields, but affects all option subclasses.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread geoapps_utils/base.py
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.44%. Comparing base (a8101df) to head (0ac65ba).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    86.40%   86.44%   +0.04%     
===========================================
  Files           18       18              
  Lines          971      974       +3     
  Branches       128      128              
===========================================
+ Hits           839      842       +3     
  Misses          97       97              
  Partials        35       35              
Files with missing lines Coverage Δ
geoapps_utils/base.py 85.34% <100.00%> (+0.23%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benk-mira
benk-mira merged commit a1e5ced into develop Oct 1, 2026
24 checks passed
@benk-mira
benk-mira deleted the GEOPY-2972 branch October 1, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants