Skip to content

GEOPY-753: Add Gravity surveys as option with runtest #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domfournier merged 2 commits into from
Oct 5, 2026
Merged

GEOPY-753: Add Gravity surveys as option with runtest #484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efce37b
Change type of synthetic survey for gravity
domfournier Sep 29, 2026
2a1216d
Merge branch 'develop' into GEOPY-753
domfournier Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions simpeg_drivers/utils/synthetics/surveys/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
from geoapps_utils.utils.transformations import rotate_xyz
from geoh5py import Workspace
from geoh5py.objects import ObjectBase, Points
from geoh5py.objects.surveys.gravity import AirborneGravity

from simpeg_drivers.utils.synthetics.options import SurveyOptions
from simpeg_drivers.utils.synthetics.surveys.frequency_domain import (
Expand Down Expand Up @@ -122,6 +123,15 @@ def get_survey(
geoh5, grid_x, grid_y, grid_z, name=options.name
)

if "gravity" in method:
return AirborneGravity.create(
geoh5,
vertices=np.column_stack(
[grid_x.flatten(), grid_y.flatten(), grid_z.flatten()]
),
name=options.name,
)

return Points.create(
geoh5,
vertices=np.column_stack(
Expand Down
27 changes: 15 additions & 12 deletions tests/run_tests/driver_grav_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
import numpy as np
from geoapps_utils.utils.importing import GeoAppsError
from geoh5py.groups import PropertyGroup
from geoh5py.objects.surveys.gravity import AirborneGravity
from geoh5py.ui_json import UIJson
from geoh5py.workspace import Workspace
from pandas import read_csv
Expand Down Expand Up @@ -54,7 +55,7 @@ def test_gravity_fwr_run(
cell_size=(20.0, 20.0, 20.0),
refinement=(2,),
):
filepath = Path(tmp_path) / "inversion_test.ui.geoh5"
filepath = Path(tmp_path) / "inversion_test.geoh5"
with get_workspace(filepath) as geoh5:
# Run the forward
components = SyntheticsComponents(
Expand Down Expand Up @@ -89,16 +90,18 @@ def test_gravity_fwr_run(
fwr_driver = GravityForwardDriver(params)
fwr_driver.run()

assert isinstance(params.data_object, AirborneGravity)


def test_gravity_run(
tmp_path: Path,
max_iterations=2,
pytest=True,
):
workpath = tmp_path / "inversion_test.ui.geoh5"
workpath = tmp_path / "inversion_test.geoh5"
if pytest:
shutil.copy(
tmp_path.parent / "test_gravity_fwr_run0" / "inversion_test.ui.geoh5",
tmp_path.parent / "test_gravity_fwr_run0" / "inversion_test.geoh5",
tmp_path,
)

Expand Down Expand Up @@ -169,7 +172,7 @@ def test_gravity_run(
driver.directives.directive_list[0].chifact_target, 0.8888, decimal=3
)

with open(workpath.parent / "inversion_test.ui.log", encoding="utf8") as file:
with open(workpath.parent / "inversion_test.log", encoding="utf8") as file:
content = file.read()
assert "Target Misfit: 8.00e+00 (8 data with chifact = 1.0)" in content
assert "IRLS Start Misfit: 8.00e+00 (8 data with chifact = 1.0)" in content
Expand Down Expand Up @@ -200,8 +203,8 @@ def test_gravity_run(

output["data"] = orig_gz

assert len(run_ws.get_entity("inversion_test.ui.log")) == 2
assert len(run_ws.get_entity("inversion_test.ui.out")) == 1
assert len(run_ws.get_entity("inversion_test.log")) == 2
assert len(run_ws.get_entity("inversion_test.out")) == 1

check_target(output, target_run)
nan_ind = np.isnan(run_ws.get_entity("Iteration_0_model")[0].values)
Expand All @@ -212,28 +215,28 @@ def test_gravity_run(
def test_restart_run(tmp_path):
shutil.copy(tmp_path.parent / "test_gravity_run0" / "Inv_run.ui.json", tmp_path)
shutil.copy(
tmp_path.parent / "test_gravity_run0" / "inversion_test.ui.geoh5", tmp_path
tmp_path.parent / "test_gravity_run0" / "inversion_test.geoh5", tmp_path
)
json_file = tmp_path / "Inv_run.ui.json"

# Remember the last iteration
out_array = read_csv(
tmp_path.parent / "test_gravity_run0/inversion_test.ui.out", sep=" "
tmp_path.parent / "test_gravity_run0/inversion_test.out", sep=" "
)

last_beta = out_array["beta"].iloc[-1]
last_phi_d = out_array["phi_d"].iloc[-1]
last_phi_m = out_array["phi_m"].iloc[-1]

uijson = UIJson.read(json_file)
uijson.geoh5 = tmp_path / "inversion_test.ui.geoh5"
uijson.geoh5 = tmp_path / "inversion_test.geoh5"
uijson.set_values(max_global_iterations=5)
uijson.write(json_file)
GravityInversionDriver.start(json_file, start_iteration=-2)

# Read the out file again and check against the previous full run
with Workspace(tmp_path / "inversion_test.ui.geoh5") as ws:
out_file = ws.get_entity("inversion_test.ui.out")[0]
with Workspace(tmp_path / "inversion_test.geoh5") as ws:
out_file = ws.get_entity("inversion_test.out")[0]
out_array = read_csv(BytesIO(out_file.file_bytes), sep=" ")
np.testing.assert_almost_equal(out_array["beta"].iloc[4], last_beta, decimal=1)
np.testing.assert_almost_equal(
Expand All @@ -247,7 +250,7 @@ def test_restart_run(tmp_path):
def test_array_too_large_run(
tmp_path: Path,
):
workpath = tmp_path.parent / "test_gravity_fwr_run0" / "inversion_test.ui.geoh5"
workpath = tmp_path.parent / "test_gravity_fwr_run0" / "inversion_test.geoh5"

with Workspace(workpath) as geoh5:
components = SyntheticsComponents(geoh5)
Expand Down
Loading