Repository navigation
GEOPY-3041: Create Data groups for L2 and LP iterations on predicted data - #173
Merged
Merged
Conversation
github-actions
Bot
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the GeoH5 save-grouping helper for IRLS workflows by renaming the LP/L2 grouping class and adjusting the property-group names to better reflect “iterations” rather than “models”.
Changes:
- Renamed
SaveLPModelGrouptoSaveLPIterationsGroup. - Updated GeoH5 property-group base names from
"L2 models"/"LP models"to"L2 iterations"/"LP iterations". - Updated the
simpeg.directivesexports to expose the renamed class.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
simpeg/directives/_save_geoh5.py |
Renames the LP/L2 grouping helper class and updates the GeoH5 group naming strings. |
simpeg/directives/__init__.py |
Updates the public export to the renamed class (needs backward-compatible alias to avoid breaking imports). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gmcga
self-requested a review
September 1, 2026 15:43
gmcga
suggested changes
Sep 1, 2026
gmcga
left a comment
gmcga
left a comment
There was a problem hiding this comment.
See copilot comment about preserving the existing import name, otherwise looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3041 - Create Data groups for L2 and LP iterations on predicted data