Skip to content

Replace CS0414 warning suppression pragmas with internal Name properties across StateVisualizer effects #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
keveleigh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Replace CS0414 warning suppression pragmas with internal Name properties across StateVisualizer effects #1143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions org.mixedrealitytoolkit.uxcore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/).

* Added `AlphaBlend` tint mode to `TintEffect`. [PR #1131](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1131)

### Changed

* Replaced `#pragma warning disable CS0414` with `Name` properties across `StateVisualizer` effects. [PR #1143](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1143)

### Fixed

* Fixed "leaked managed shell" issue in `UGUIInputAdapter`. [PR #1096](https://github.com/MixedRealityToolkit/MixedRealityToolkit-Unity/pull/1096)
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/AnimationEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ internal class AnimationEffect : PlayableEffect, IAnimationMixableEffect
{
[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Animation";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("The animation clip for this effect.")]
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/PlayableAssetEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ internal class PlayableAssetEffect : PlayableEffect
{
[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Playable Asset";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("The scriptable object containing the effect.")]
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/SetTargetsActiveEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ internal class SetTargetsActiveEffect : IEffect
{
[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Set Targets Active/Inactive";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("If true, the specified objects will be set inactive when the state is on, and vice versa.")]
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/SpriteSwapEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,12 @@ internal class SpriteSwapEffect : IEffect
{
[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Sprite Swap";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("Threshold value to activate this effect. When the state value is above this number, the effect will activate.")]
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/TintEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,9 +206,12 @@ internal enum BlendType

[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Tint";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("The duration of the transition from un-tinted to tinted.")]
Expand Down
7 changes: 5 additions & 2 deletions org.mixedrealitytoolkit.uxcore/StateVisualizer/Effects/TwoWayAnimationEffect.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,12 @@ internal class TwoWayAnimationEffect : PlayableEffect, IAnimationMixableEffect
{
[SerializeField]
[HideInInspector]
#pragma warning disable CS0414 // Inspector uses this as a helpful label in lists.
private string name = "Two Way Animation";
#pragma warning restore CS0414 // Inspector uses this as a helpful label in lists.

/// <summary>
/// The display name of this effect.
/// </summary>
internal string Name => name;

[SerializeField]
[Tooltip("The animation clip for the forward direction.")]
Expand Down
Loading