Repository navigation
Phase 4 — System Observatory telemetry - #7
Merged
Merged
Conversation
Cover TelemetryStore publish/overwrite lifecycle, the IPC telemetry-disabled path, network Offline state, disk and network counter overflow saturation, disk whole-device name edge cases, telemetry environment toggle parsing, and protocol SamplerUnavailable round-trips plus the maximum-width snapshot payload bound. 121 workspace tests pass, Clippy clean, and the full release gate holds.
cargo fmt --check flagged the loopback-offline fixture added in 43ebb59. No behavior change; unblocks ./scripts/velora.sh all.
MoazMustafa-stack
added a commit
that referenced
this pull request
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 (P4.01–P4.12) is code-complete: protocol v4, CPU/memory/disk/network samplers, bounded telemetry service, Godot client + observatory HUD, privacy toggle (VELORA_TELEMETRY_ENABLED), parser fault hardening, resource budget, and release gate (scripts/check-phase-four.sh).
Validation on branch: cargo fmt clean, cargo clippy clean (-D warnings), 117 workspace tests pass, Godot validation suite passes, static security checks pass, gate PASS (idle 0.0% CPU, ~28 KiB RSS growth over 5s, within budget).
Includes 9 perf commits between P4.06 and P4.07 (bridge delivery, session lookups, allocation reduction) plus a fmt fix for the network offline-fixture test that unblocked ./scripts/velora.sh all.
Note: single PR (not the planned #10/#11/#12 split) because Phase 3 merged directly to main and never consumed #7–#9, and the 19 commits are linear.