Skip to content

Frontend UI foundation: tokens, panels, settings and modal input - #9

Merged
MoazMustafa-stack merged 13 commits into
mainfrom
frontend-ui-foundation
Sep 26, 2026
Merged

MoazMustafa-stack merged 13 commits into
mainfrom
frontend-ui-foundation

Conversation

@MoazMustafa-stack

Copy link
Copy Markdown
Owner

Summary

Implement D6.01–D6.04 from merged Phase 5 main (5bdf1dc) in focused stages:

  • semantic design tokens and an asset/visual inventory; token migration preserves pixels
  • composed panel shell and bounded list cursor; migrate notifications, media, then workspace map
  • stable workspace selection, readable grid cells and bounded 20-cell layout
  • versioned, bounded UI-only settings API with typed accessors, atomic save and isolated reset; remove the unused protocol-v1 config
  • one modal coordinator for input lock, focus/prompt recovery and stale-close protection
  • named InputMap actions with existing keyboard defaults and context-specific media controls
  • deterministic foundation tests and synthetic native/scaled visual fixtures

Validation and review

  • ./scripts/velora.sh gate: 224 Rust tests, strict Clippy, all prior Godot suites plus five foundation suites, security and resource gates
  • ./scripts/check-ipc.sh: isolated restart/reconnect without real app launches
  • ./scripts/check-dev.sh: normal exit and signal cleanup
  • ./scripts/velora.sh perf: Intel UHD CML GT2 / Wayland / Compatibility, 60.00 FPS average and 17.09 ms p95 (baseline 60.00 FPS / 18.43 ms)
  • Input-action and overlay tests also run through the rendered Wayland engine
  • Token-only before/after hub/feed/media/workspace frames are byte-identical
  • Agent inspected native and integer-scaled synthetic layouts, long strings, empty/unavailable/restricted/stale states, populated media, full 20-cell map and pause
  • Review fixes: reserve counter width, prevent collapsed/overflowing workspace grid, bound settings reads even if files grow
  • git diff --check; no private docs, caches, live data or unrelated media in the diff

Detailed evidence and known boundaries: frontend/godot/FOUNDATION_REVIEW.md.
This is an implementation self-review, not an independent human approval.
Phase 5 live-session acceptance was confirmed by the owner on PR #8; new rendered tests use synthetic input/data.

Safety and scope

No new Core handlers, protocol changes, OS commands or Omarchy/Hyprland configuration writes.
Settings never persist notifications, media, telemetry or registry snapshots. Tests inject disposable paths.
Stored desktop IDs do not bypass live registry resolution or Core policy.

D6.05–D6.13 remain: world art/layout, HUD priority and pause copy, onboarding/help,
accessibility, audio, remapping/controller UI, station customization and final Phase 6 gate.

CI limitation

The account's preceding CI check did not execute because GitHub reported:
“The job was not started because your account is locked due to a billing issue.”
The local evidence above is passing; GitHub CI is not claimed to have passed.
The new PR check will be inspected separately before merge.

@MoazMustafa-stack MoazMustafa-stack left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed head 268f5394157625f3d28c14fe74aeda8821550c92 against main 5bdf1dc.

No remaining blocking findings in D6.01–D6.04 after the counter-width, full-grid clipping and bounded-settings-read fixes. Reviewed state ownership, default keyboard reachability, settings allowlists, stable selection, privacy, rendered layout and performance. This is an implementation self-review, not independent human approval.

Local cumulative gate, 224 Rust tests, all frontend suites, rendered input/overlay checks, synthetic native/scaled visual inspection, isolated IPC restart and supervisor cleanup passed. Intel UHD performance: 60 FPS / 17.09 ms p95. Full evidence and remaining scope are recorded in frontend/godot/FOUNDATION_REVIEW.md.

Fresh CI run 36225873744, check 108359687974, concluded failure without starting. Exact annotation: “The job was not started because your account is locked due to a billing issue.” CI did not pass. As explicitly authorized by the owner, the passing local gate is used for this merge checkpoint.

No private docs, unrelated media, caches, Core/protocol changes or system configuration changes appear in the PR. D6.05–D6.13 remain; the next card is D6.05.

@MoazMustafa-stack
MoazMustafa-stack merged commit 57cfcb6 into main Sep 26, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant