Repository navigation
Record the EWKB writers of the spatial types in the Spark gaps ledger - #159
Merged
estebanzimanyi merged 1 commit intoOct 5, 2026
Conversation
tools/spark-udf-gaps.txt lists the 11 public MEOS EWKB writers the Spark UDF surface does not reach: cbuffer_as_ewkb, npoint_as_ewkb, nsegment_as_ewkb, pose_as_ewkb, posechain_as_ewkb, spatialset_as_ewkb, stbox_as_ewkb, tpcbox_as_ewkb and tspatial_as_ewkb, which return their bytes through a size_t * out-parameter as a uint8_t *, and posechain_as_hexewkb and tpcbox_as_hexewkb, which take that out-parameter, as the ledger lists posechain_as_wkb, posechain_as_hexwkb, tpcbox_as_wkb and tpcbox_as_hexwkb. The plain writers of the other types are reached as the byte codec of their value type, which the E writers are not. Witness: over the catalog and libmeos of MobilityDB 34247bccf3 and MEOS-API 0438baabc6, codegen_jvm.py --engine spark --gaps tools/spark-udf-gaps.txt on main exits 1, "11 public functions the surface does not reach and the ledger does not list", naming these 11. Measured over the same pair: --rebaseline adds these 11 lines and changes no other; the check passes, the ledger at 762 functions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/spark-udf-gaps.txt lists the 11 public MEOS EWKB writers the Spark UDF surface does not
reach: cbuffer_as_ewkb, npoint_as_ewkb, nsegment_as_ewkb, pose_as_ewkb, posechain_as_ewkb,
spatialset_as_ewkb, stbox_as_ewkb, tpcbox_as_ewkb and tspatial_as_ewkb, which return their bytes
through a size_t * out-parameter as a uint8_t *, and posechain_as_hexewkb and tpcbox_as_hexewkb,
which take that out-parameter, as the ledger lists posechain_as_wkb, posechain_as_hexwkb,
tpcbox_as_wkb and tpcbox_as_hexwkb. The plain writers of the other types are reached as the byte
codec of their value type, which the E writers are not.
Witness: over the catalog and libmeos of MobilityDB 34247bccf3 and MEOS-API 0438baabc6,
codegen_jvm.py --engine spark --gaps tools/spark-udf-gaps.txt on main exits 1, "11 public
functions the surface does not reach and the ledger does not list", naming these 11.
Measured over the same pair: --rebaseline adds these 11 lines and changes no other; the check
passes, the ledger at 762 functions.