Skip to content

Redundant training config parameter ffn_hidden in the case of SwiGLU #276

Open

Description

@flxst

The training config parameter ffn_hidden, see e.g. here, currently needs to be specified (as a multiple of 128) although it is only actually used in the case of GeLU. In contrast, if SwiGLU is used, the effective hidden dimension is automatically derived from n_embd instead, see here.

This is misleading and should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions