Skip to content

[ABL] Weight Tying raises errors when running distributed checkpointing #348

Closed

Description

@le1nux

NOTE: weight tying does not seem to work with distributed checkpointing

E         File "/raid/s3/opengptx/max_lue/repositories/modalities/src/modalities/checkpointing/stateful/app_state.py", line 105, in load_state_dict
E           OptimizerStateRetriever.load_state_dict_(
E         File "/raid/s3/opengptx/max_lue/repositories/modalities/src/modalities/checkpointing/stateful/app_state.py", line 175, in load_state_dict_
E           set_optimizer_state_dict(
E         File "/raid/s3/opengptx/max_lue/venvs/modalities_311/lib/python3.11/site-packages/torch/distributed/checkpoint/state_dict.py", line 1246, in set_optimizer_state_dict
E           _load_optim_state_dict(model, optimizers, optim_state_dict, info)
E         File "/raid/s3/opengptx/max_lue/venvs/modalities_311/lib/python3.11/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
E           return func(*args, **kwargs)
E                  ^^^^^^^^^^^^^^^^^^^^^
E         File "/raid/s3/opengptx/max_lue/venvs/modalities_311/lib/python3.11/site-packages/torch/distributed/checkpoint/state_dict.py", line 891, in _load_optim_state_dict
E           optim_state_dict = _unflatten_optim_state_dict(
E                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E         File "/raid/s3/opengptx/max_lue/venvs/modalities_311/lib/python3.11/site-packages/torch/distributed/checkpoint/state_dict.py", line 716, in _unflatten_optim_state_dict
E           cast(DictValueType, state[fqn])[state_name] = state_dict[
E                                                         ^^^^^^^^^^^
E       KeyError: 'state.transformer.lm_head.weight.step'

Originally posted by @le1nux in #336

Activity

  1. added theissue type on Oct 8, 2025
  2. changed the title [-]Weight Tying raises errors when running distributed checkpointing[/-] [+][ABL] Weight Tying raises errors when running distributed checkpointing[/+] on Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't working

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions