Add proguard-shield - #338
Merged
Merged
Conversation
CI and check.sh run proguardShieldFast only, so drop the accurate releaseRules.txt baseline and re-baseline with proguardShieldFastBaseline, which doesn't run R8 or regenerate releaseRules.txt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Upxj1FvQeDpycupKdPQHUZ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect unintended changes to the merged ProGuard/R8 rules of the release APK, as
manifestShielddoes for the merged manifest.io.github.fornewid.proguard-shield0.0.3 to:appwithconfiguration("release")app/proguardShield/releaseFastRules.txt(the accuratereleaseRules.txtis not committed)./gradlew proguardShieldFastin CI andcheck.sh(the fast path, which doesn't run R8)Parity holds on AGP 8.13.2:
proguardShieldVerifyParityconfirmed the fast baseline is byte-identical to R8's-printconfigurationoutput.If a rule change is intended, re-baseline with
./gradlew proguardShieldFastBaseline.