Repository navigation
adds lizard animids, plus a few refactors #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
2bcea22
does basically everything needed for the base state, ahhh
Wollywoger 72648c4
refactors, other things being tidied up
Wollywoger 133853d
Apply first batch of suggestions
Wollywoger 3c2f5da
second batch of review changes
Wollywoger 588852b
Update maplestation.dme
Wollywoger 7846267
added the override color to tailspines, because they didn't inherit t…
Wollywoger f26dcde
Merge branch 'lizard_animids' of https://www.github.com/wollywoger/ma…
Wollywoger e84af00
Update code/datums/bodypart_overlays/mutant_bodypart_overlay.dm
Wollywoger a1dd6e4
changes frills to mutant_override
Wollywoger daff8b1
Merge branch 'lizard_animids' of https://www.github.com/wollywoger/ma…
Wollywoger dc1037c
Merge branch 'master' into lizard_animids
Wollywoger b5d7882
updates map icons
Wollywoger a46a426
Merge branch 'lizard_animids' of https://www.github.com/wollywoger/ma…
Wollywoger f55461d
calms down screenshot tests by adding the right screenshots
Wollywoger 4f1b6c3
there was a double underline and i got the filename wrong
Wollywoger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+1.25 KB
...t_tests/screenshots/screenshot_humanoids__datum_species_human_animid_Lizard.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
maplestation_modules/code/datums/bodypart_overlays/mutant_bodypart_overlay.dm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| // used for additional stuff on mutant bodypart overlays | ||
|
|
||
| // used by "ORGAN_COLOR_MUTANT_OVERRIDE" but can also be used by other organs' color overrides | ||
| /datum/bodypart_overlay/mutant/proc/mutant_override_color(obj/item/bodypart/bodypart_owner) | ||
| // use body color if we should be mutant colored | ||
| if(isnull(bodypart_owner.owner) || HAS_TRAIT(bodypart_owner.owner, TRAIT_MUTANT_COLORS) || HAS_TRAIT(bodypart_owner, TRAIT_MUTANT_COLORS)) | ||
| return bodypart_owner.draw_color | ||
| // first try to use forced color - for non-mutant-colored species, like piscinids | ||
| // then default to body color - though this will probably be skin color, some other forced color, or pure white | ||
| return bodypart_owner.owner.dna.features["forced_mut_color"] || bodypart_owner.draw_color | ||
|
|
||
| // todo: figure out how on god's green earth functional wings even get their color, also refactor that part of the code and push it to TG | ||
| /datum/bodypart_overlay/mutant/wings/functional/mutant_color | ||
| color_source = ORGAN_COLOR_MUTANT_OVERRIDE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 65 additions & 0 deletions
65
...tation_modules/code/modules/mob/living/carbon/human/species_types/animid/animid_lizard.dm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /datum/animid_type/lizard | ||
| id = "Lizard" | ||
| components = list( | ||
| BODY_ZONE_CHEST = /obj/item/bodypart/chest/scaled, | ||
| BODY_ZONE_HEAD = /obj/item/bodypart/head/scaled, | ||
| BODY_ZONE_L_ARM = /obj/item/bodypart/arm/left/scaled, | ||
| BODY_ZONE_L_LEG = /obj/item/bodypart/leg/left/scaled, | ||
| BODY_ZONE_R_ARM = /obj/item/bodypart/arm/right/scaled, | ||
| BODY_ZONE_R_LEG = /obj/item/bodypart/leg/right/scaled, | ||
| MUTANT_ORGANS = list( | ||
| /obj/item/organ/horns = SPRITE_ACCESSORY_NONE, | ||
| /obj/item/organ/frills = SPRITE_ACCESSORY_NONE, | ||
| /obj/item/organ/spines = SPRITE_ACCESSORY_NONE, | ||
| /obj/item/organ/tail/lizard = /datum/sprite_accessory/tails/lizard/smooth::name, | ||
| ), | ||
| ) | ||
|
|
||
| name = "Reptilid" | ||
| icon = FA_ICON_DRAGON | ||
|
|
||
| /datum/animid_type/lizard/pre_species_gain(datum/species/human/animid/species, mob/living/carbon/human/new_animid) | ||
| // ensures we get mutant color rather than a random forced color | ||
| new_animid.dna?.features["forced_mut_color"] = new_animid.dna?.features["mcolor"] | ||
| species.mutanttongue = new_animid.dna?.features["hissing"] ? /obj/item/organ/tongue/lizard : /obj/item/organ/tongue/lizard/no_hiss | ||
|
|
||
| /datum/animid_type/lizard/extra_feature_keys() | ||
| return list(/datum/preference/color/mutant_color::savefile_key) | ||
|
|
||
| /datum/animid_type/lizard/get_readable_features() | ||
| return ..() + "Scales" | ||
|
|
||
| /datum/animid_type/lizard/get_extra_perks() | ||
| var/list/to_add = list() | ||
|
|
||
| to_add += list( | ||
| list( | ||
| SPECIES_PERK_TYPE = SPECIES_NEUTRAL_PERK, | ||
| SPECIES_PERK_ICON = FA_ICON_HAND_FIST, | ||
| SPECIES_PERK_NAME = "Scaled Defense", | ||
| SPECIES_PERK_DESC = "[name] scales provide a minor amount of resistance to bruises and burns. \ | ||
| However, good luck disguising your scaled skin.", | ||
| ), | ||
| ) | ||
|
|
||
| return to_add | ||
|
|
||
| /datum/preference/toggle/liz_tongue_hissing | ||
| savefile_key = "liz_tongue_hissing" | ||
| savefile_identifier = PREFERENCE_CHARACTER | ||
| category = PREFERENCE_CATEGORY_SECONDARY_FEATURES | ||
| can_randomize = FALSE | ||
| default_value = FALSE | ||
|
|
||
| /datum/preference/toggle/liz_tongue_hissing/apply_to_human(mob/living/carbon/human/target, value) | ||
| // behavior is only applied on animids by default | ||
| target.dna.features["hissing"] = value | ||
|
|
||
| /datum/preference/toggle/liz_tongue_hissing/is_accessible(datum/preferences/preferences) | ||
| return ..() && ((ispath(preferences.read_preference(/datum/preference/choiced/species), /datum/species/human/animid)) && (preferences.read_preference(/datum/preference/choiced/animid_type) == /datum/animid_type/lizard::id)) | ||
|
|
||
| /obj/item/organ/tongue/lizard/no_hiss // because modifies_speech only affects things on init | ||
| name = "mutated forked tongue" | ||
| desc = "A thin and long muscle typically found in reptilian races, apparently moonlights as a nose. The ends on this one appear more rigid than normal, reducing the amount of hissing." | ||
| modifies_speech = FALSE // no hiss for you | ||
| draw_length = 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.