[rlcee]

No description provided.

[FNALbuild]

Hi @rlcee,
You have proposed changes to files in these packages:

• DbService

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

⌛ The following tests have been triggered for 0bf45be: build (Build queue - API unavailable)

About FNALbuild. Code review on Mu2e/Offline.

[FNALbuild]

☀️ The build tests passed at 0bf45be.

Test	Result	Details
test with	✅	Command did not list any other PRs to include
merge	✅	Merged 0bf45be at b8cfd1d
build (prof)	✅	Log file. Build time: 09 min 05 sec
ceSimReco	✅	Log file.
g4test_03MT	✅	Log file.
transportOnly	✅	Log file.
POT	✅	Log file.
g4study	✅	Log file.
cosmicSimReco	✅	Log file.
cosmicOffSpill	✅	Log file.
ceSteps	✅	Log file.
ceDigi	✅	Log file.
muDauSteps	✅	Log file.
ceMix	✅	Log file.
rootOverlaps	✅	Log file.
g4surfaceCheck	✅	Log file.
trigger	✅	Log file.
check_cmake	✅	Log file.
FIXME, TODO	✅	TODO (0) FIXME (0) in 0 files
clang-tidy	✅	0 errors 0 warnings
whitespace check	✅	no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0bf45be after being merged into the base branch at b8cfd1d.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

[oksuzian]

PR Review Summary — #2049

Reviewed at head 0bf45be4cc62da5cb1877f954d04a50f732dec99. first pass

Decision

• 🟢 approve. The new cal.timecalib table matches the CalTimeCalib class that already reads it, and it follows its sibling cal.energycalib line for line.

Scope understood

• Adds the SQL schema for cal.timecalib (cid, roid, tcorr, primary key (cid,roid), SELECT to PUBLIC, INSERT to cal_role) to DbService/data/create.sql.
• The C++ side is already on main. DbTables/inc/CalTimeCalib.hh reads cal.timecalib with columns roid,tcorr. DbTableFactory registers it, and CalCalibCache combines it with CalEnergyCalib into the CalCalib proditions object that CaloRecoDigiMaker and CaloHitMakerFast use (Offline#2030). This PR only adds the table the database needs to hold those rows.
• The PR has no description. A line saying "schema for the CalTimeCalib table read since #2030" would help whoever applies it to the database.

Findings

• None.

🟢 Checked:

• Columns match the reader. CalTimeCalib queries roid,tcorr, ordered by roid. addRow parses column 0 as the channel index and column 1 as a float correction in ns. The SQL has roid INTEGER and tcorr NUMERIC, with cid handled by DbTable as for every other table.
• Same pattern as the siblings. cal.energycalib (roid, adc2mev NUMERIC), cal.channelstatus and cal.channels all use cid INTEGER, a cal_<name>_pk PRIMARY KEY (cid, <id>), GRANT SELECT ... TO PUBLIC and GRANT INSERT ... TO cal_role. The new block differs from cal.energycalib only in the table name and the value column. The cal schema and its USAGE grant already exist.
• No job reads it by default yet. CaloConditions/fcl/prolog.fcl has CalCalib.useDb: false with timeoffset: 0.0. Adding the schema changes no job output.

Validation check

• Build/tests run: FNALbuild passed at this head (build 3474, merged at b8cfd1d7), including trigger. No CI job loads create.sql, so the build does not test this change. Locally, I compared the table against CalTimeCalib.hh and the sibling tables on main.
• Config contract check: pass.
• Cross-repo consistency: not applicable.

Residual risk

• Not checked: the production database itself. I don't know whether cal.timecalib already exists there, or how this file is applied.
• For context, not for this PR: several other cal.* table classes on main have no create.sql entry either (cal.baselines, cal.cosmictimecalib, cal.laserenergycalib, cal.sourceenergycalib, among others). I assume they are created elsewhere or are ad hoc.

Author follow-ups

• Optional: a one-line PR description.