Repository navigation
fix: 单人模式部分贴图裁剪 - #149
Merged
Merged
fix: 单人模式部分贴图裁剪#149
Conversation
审查者指南(小型 PR 中折叠显示)审查者指南该 PR 通过修补当前的 ScreenClipSetter.SetClipX 实现,将异常狭窄的水平裁剪范围扩展为全屏,从而修复单人模式下的贴图裁剪问题,而不是禁用之前的背景控制器方法。 单人模式贴图裁剪修正时序图sequenceDiagram
participant ScreenClipSetter
participant HarmonyPatch
ScreenClipSetter->>HarmonyPatch: SetClipX(minX, maxX)
HarmonyPatch->>HarmonyPatch: [maxX <= 0.5f]
HarmonyPatch->>HarmonyPatch: minX = 0f
HarmonyPatch->>HarmonyPatch: maxX = 1f
HarmonyPatch-->>ScreenClipSetter: Continue with corrected clip range
文件级变更
针对关联 Issue 的评估
可能关联的 Issue
提示和命令与 Sourcery 交互
自定义使用体验访问你的控制面板以:
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR fixes single-player texture cropping by patching the current ScreenClipSetter.SetClipX implementation and expanding unusually narrow horizontal clip ranges to the full screen, rather than disabling the previous background-controller method. Sequence diagram for single-player texture clip correctionsequenceDiagram
participant ScreenClipSetter
participant HarmonyPatch
ScreenClipSetter->>HarmonyPatch: SetClipX(minX, maxX)
HarmonyPatch->>HarmonyPatch: [maxX <= 0.5f]
HarmonyPatch->>HarmonyPatch: minX = 0f
HarmonyPatch->>HarmonyPatch: maxX = 1f
HarmonyPatch-->>ScreenClipSetter: Continue with corrected clip range
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #148
如图所示,使用此方案后修复了问题,其恢复正常 (注:达成率问题为其他 mod 导致)