Skip to content

fix: 给ScreenClipSetterSetClipX补上noWarn。不然老版本的会打一个莫名其妙的警告 - #152

Merged
clansty merged 1 commit into
MuNET-OSS:mainfrom
Starrah:fix-ScreenClipSetterSetClipX-nowarn
Sep 20, 2026
Merged

clansty merged 1 commit into
MuNET-OSS:mainfrom
Starrah:fix-ScreenClipSetterSetClipX-nowarn

Conversation

@Starrah

@Starrah Starrah commented Sep 19, 2026 •

Copy link
Copy Markdown
Collaborator

老版本(165之前)现在会打印出这样的警告。但其实只是因为ScreenClipSetterSetClipX不适用于165之前,而不是SinglePlayer整个不适用,所以这个警告显得莫名其妙的。
image

Review in cubic

Sourcery 摘要

错误修复:

  • 抑制受版本限制的补丁所产生的不支持版本警告,使较旧的游戏版本不再报告误导性的兼容性警告。
Original summary in English

Summary by Sourcery

Bug Fixes:

  • Suppress unsupported-version warnings for version-gated patches so older game versions no longer report misleading compatibility warnings.

@sourcery-ai

sourcery-ai Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
审查者指南(在较小的 PR 中折叠)

审查者指南

更新了两处 EnableGameVersion(27000) 声明,以抑制在 165 之前版本中的警告,明确说明不可用的只是特定补丁,而不是更广泛的功能或模组功能。

文件级变更

变更 详细信息 文件
抑制针对版本受限补丁的误导性“不支持版本”警告;这些补丁在较旧的游戏版本上是有意停用的。
  • 为 credit/ticket 补丁的 EnableGameVersion 属性传入 noWarn: true。
  • 为 ScreenClipSetter.SetClipX SinglePlayer 补丁的 EnableGameVersion 属性传入 noWarn: true。
AquaMai.Mods/GameSettings/CreditConfig.cs
AquaMai.Mods/GameSystem/SinglePlayer.cs

提示和命令

与 Sourcery 互动

  • 触发新的审查: 在拉取请求中评论 @sourcery-ai review。
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 根据审查评论创建 GitHub issue: 回复审查评论,请 Sourcery 根据该评论创建 issue。你也可以使用 @sourcery-ai issue 回复审查评论,以根据该评论创建 issue。
  • 生成拉取请求标题: 在拉取请求标题的任意位置写入 @sourcery-ai,即可随时生成标题。你也可以在拉取请求中评论 @sourcery-ai title,以随时(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文的任意位置写入 @sourcery-ai summary,即可在指定位置随时生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary,以随时(重新)生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可随时(重新)生成审查者指南。
  • 解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可解决所有 Sourcery 评论。如果你已经处理完所有评论且不想再看到它们,这会很有用。
  • 忽略所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。如果你想从新的审查开始,这尤其有用——别忘了评论
    @sourcery-ai review 来触发新的审查!

自定义你的使用体验

访问你的控制面板以:

  • 启用或禁用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、移除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates two EnableGameVersion(27000) declarations to suppress warnings on pre-165 versions, clarifying that only the specific patches are unavailable rather than the broader features or mod functionality.

File-Level Changes

Change Details Files
Suppresses misleading unsupported-version warnings for version-gated patches that are intentionally inactive on older game versions.
  • Passes noWarn: true to the EnableGameVersion attribute for the credit/ticket patch.
  • Passes noWarn: true to the EnableGameVersion attribute for the ScreenClipSetter.SetClipX SinglePlayer patch.
AquaMai.Mods/GameSettings/CreditConfig.cs
AquaMai.Mods/GameSystem/SinglePlayer.cs

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

你好——我已经审阅了你的更改,看起来非常棒!

Sourcery 评估

已批准。


Sourcery 对开源项目免费——如果你喜欢我们的审阅结果,请考虑分享 ✨
Original comment in English

Hey - I've reviewed your changes and they look great!

Sourcery assessment

Approved.


Sourcery is free for open source - if you like our reviews please consider sharing them ✨

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@clansty

clansty commented Sep 20, 2026

Copy link
Copy Markdown
Member

那似乎,很多东西都应该加这个(

@clansty
clansty merged commit a714c86 into MuNET-OSS:main Sep 20, 2026
5 checks passed
@Starrah
Starrah deleted the fix-ScreenClipSetterSetClipX-nowarn branch September 20, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants