Repository navigation
Insights 6c: personal time estimates (option C) behind INSIGHTS_PUBLIC - #277
Merged
Merged
Conversation
…C - WIP GetPersonalEstimates (one statement per list), ResolvePersonalEstimates, the puzzle page card, one line per list row (collections, wishlist, unsolved, Picker, marketplace), the sheet, estimated corners, ShelfPicks::estimates() wired to the picture estimate where its gate passed, 6 locales, tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… in 6 locales, docs - GetPersonalEstimates: the listed ids drive the statement, the player's part rides on one row (21 puzzles 3-8 ms, a 1,350-puzzle collection 50-83 ms on the production copy) - the list line's column takes the row's width; chip label dropped by locale-aware container queries (6 locales x 320-414 px, 41,550 lines, no clipped time) - docs/features/insights/estimates.md (the one rule of which number shows), flag doc, related docs - GetPersonalEstimates allow-listed in BlocklistQueryCoverageTest (own data, aggregates only) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- the gate vouches only for the estimate generation its record measured (image_model + version must be among the group's estimateModels); derive model changes stay closed until evaluated - tests + image-estimate-gates.md - Picker "vs your best" from the raw prediction, silent under the shown time's rounding step - the sheet gives the focus back; selection mode ignores taps on the estimate line - the 50 % window and the 80 % range shown together share one style (PredictionWindowFormatter::ranges()) - collections "+ predictions" mode skips GetPlayerPredictions while the estimate line shows - flag-off base.html.twig byte-identical; est-host only on rows with an estimate; card a11y "(estimated)" once - "Likely the hardest …" on an estimated tier, Czech / Spanish agreement, all 6 locales - statement budgets pinned with the flag on (puzzle page, Picker, custom collection); TODO.md follow-ups Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insights Phase 6c (
docs/features/insights/implementation-plan.md§6.2): personal time estimates, option C, mobile first. BehindINSIGHTS_PUBLIC: with the flag off, non-admins get byte-identical HTML and the same statement counts on every touched surface.What changes
Puzzle page card:
Lists (collections, wishlist, unsolved, Puzzle Picker cards, marketplace cards):
Which number shows (
docs/features/insights/estimates.md). The same puzzle never shows two different times; this is pinned by a parity test againstGetPlayerPrediction.ImageEstimateGate::passesFor()passes for that estimate generationRounding: 5 min under an hour, 10 min above, to the minute under 10 min. Never outside the shown window. "≈" in lists.
Accessibility: an estimate is never marked by colour alone (dashed outline + "?" + "estimated" in the accessible name). The sheet returns focus to its trigger.
Statements with the flag on:
GetPlayerPredictionstatementsGetPlayerPredictionsThe biggest collection (1,351 puzzles) takes 16-83 ms on the production copy.
No migration.
Reviewed
An independent review found no blockers. All its findings are fixed:
All 6 locales are covered: 44 keys, with matching placeholders.
🤖 Generated with Claude Code