fix(provider): reclaim refused warm reservations - #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Incus refuses placement of a warm worker, the provider returned a successful capacity deferral and skipped reservation cleanup. Repeated attempts retained memory for workers that never existed until the admission TTL elapsed, delaying real jobs despite available capacity.
Preserve the exact reserved identity across named returns, release proven placement refusals before returning, and surface journal cleanup failures. Ambiguous create responses retain their reservation for authoritative reconciliation. Release provider v0.1.5-nddev.125 with two byte-identical builds.
Validation:
make verifypassed; regression cases cover repeated placement refusal, expired create context, cleanup failure, argument failure and ambiguous create responses. No admission limits or running-worker behavior changed.