fix(garm): keep GitHub-queued waiters through assigned TTL - #408
Merged
Conversation
Never-started assigned intents demote to queued instead of disappearing after 600s, so a still-queued GitHub job cannot lose its journal slot to a later UUID on the same label. Queued waiters refresh until the 24-hour execution horizon. FIFO follows FirstQueuedAt when reconciliation rewrites QueueTime. Job-keyed capacity refusals are cluster backpressure and no longer open a 24-hour create circuit. This is GARM v0.2.1-nddev.90. Fixes #406 Fixes #407
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub-queued jobs on
nddev-linux-releaseandnddev-priority-integrationwere starved after 600s: the assigned token was deleted, later jobs on the same label ran, and a job-keyed capacity refusal opened a 24-hour create circuit. This keeps the waiter represented and retries capacity as backpressure.Fixes #406
Fixes #407
What changed
QueueTime/FirstQueuedAt.FirstQueuedAtso reconciliation cannot move a waiter behind a later job by rewritingQueueTime.TerminalUntil. They use the same backoff and delete-wake as instance-keyed capacity.v0.2.1-nddev.90(8d55695cad2265d0cb2ad8dfaf9d49b88f61b3a9bef54539b7684c926145bf64).Verification
v0.2.1(including the new skip/refill and job-capacity cases):go test ./workers/scaleset ./workers/providermake build-garm-derivativetwice: tests green, reproducible binary digest matches the manifestmake verify(fmt, vet, race, controller-release manifest, build)Out of scope
.90host apply wait for this PR to merge