Repository navigation
Fix atomic snapshot metadata accounting (#90) - #104
Merged
Merged
Conversation
AGiorgetti
force-pushed
the
fix/90-atomic-snapshot-metadata
branch
from
November 3, 2026 12:16
88abb10 to
fa6f1ec
Compare
AGiorgetti
marked this pull request as ready for review
November 4, 2026 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #90.
Breaking change
MongoDB 4.2+ is required for update pipelines. Upgrade the server before the adapter. No stored-schema migration is needed. Version 4.2 is a feature minimum, not a recommended production version. README and changelog document this requirement.
Validation
Rebased onto
developat88fdb6b9228b0ad56642b04bab81f9a203349951, including the merged #88 and #89 fixes. The changelog conflict is resolved, and the CI workflow remains identical to the PR base.Final head
fa6f1ecc398ea3086a2b5ddc64f51011b1d53da4: exact-head standard CI passed: Windows and Ubuntu builds plus MongoDB 9 test lanes for net8/net9/net10, each 579/579 passed with zero failures and zero skips.Historical run 41542168410 at
8155b08:d12d48a: 536/536 passed, including actual-engine delayed metadata/snapshot interleavings, with zero skips. That temporary job and fixture are not retained.Stream_head_delete_by_id_should_use_the_builtin_id_indexexplain-plan assertion failed; this is not a full minimum-version suite pass. No assertion was weakened, fixed, or excluded. The temporary 4.2 job is removed at the user's request.No local build/tests were run. CI resolves Driver 3.9, not the library's declared 3.0 minimum. MongoDB 4.2 remains the documented feature minimum, not a claim of complete green minimum-version coverage.
Co-authored by Alessandro Giorgetti and Codex (OpenAI).