Repository navigation
Fix deferred MongoDB read exception translation - #106
Merged
Merged
Conversation
AGiorgetti
marked this pull request as ready for review
November 6, 2026 11:52
Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
Guard cursor acquisition and batches while retaining streaming and serializer error identity. Cover disposal guards and document exception compatibility. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
Hoist the MoveNext delegate while retaining both virtual TryMongo dispatches. Cover dispatch order and callback identity across all nine read paths, and document the observable identity change for derived engines. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
AGiorgetti
force-pushed
the
fix/91-deferred-mongo-exceptions
branch
from
November 6, 2026 11:56
e5ea11b to
240f563
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #91.
Validation
c6b005ad: CI run 41856965260 passed Windows/Linux builds. Each of net8/net9/net10 reproduced exactly 54 expected failures: raw driver exceptions escaped instead of storage exceptions; 945 other tests passed, 0 skipped.02f06f0d4c5afa6f07075009e7d19008ce51e1b6: Windows/Linux builds passed, and all 1,026 tests passed on each of net8/net9/net10 with MongoDB 9.0.4, 0 skipped. Existing CI is unchanged.Compatibility
Consumers catching raw MongoDB exceptions during iteration should catch StorageException or StorageUnavailableException instead. Keep the persistence engine alive until enumeration finishes. Serializer errors remain unchanged. No API/schema migration or dependency update is required.
Co-authored by Alessandro Giorgetti and Codex (OpenAI).