Repository navigation
fix: preserve async application exception origin (#108) - #113
Draft
AGiorgetti wants to merge 2 commits into
Draft
AGiorgetti wants to merge 2 commits into
AGiorgetti wants to merge 2 commits into
Conversation
Default async observer reads to preserve application Mongo exceptions. Add a legacy opt-out and document the breaking change. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
Return completed observer tasks directly and share the async exception-marking slow path. Preserve legacy opt-out task forwarding. Co-authored-by: Alessandro Giorgetti <alessandro.giorgetti@live.com> Co-authored-by: Codex (OpenAI) <codex@openai.com>
Member
Author
|
Refactored the per-item observer helpers at the owner's request:
Verification: 14 new identity tests failed before the change; final focused regression suite has 587 tests passing with zero skipped in all eight net472/net8/net9/net10 × Driver 3.0.0/3.13.0 lanes. Full net10/Driver 3.13.0 suite against isolated MongoDB 8: 1,680 passed, zero skipped. Independent review found no correctness blocker. No benchmark was run, so no quantified throughput/allocation improvement is claimed. Existing protected-override caveat is unchanged. Co-authored-by: Alessandro Giorgetti alessandro.giorgetti@live.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MongoPersistenceOptions.WrapAsyncApplicationExceptions = trueto restore stable 12.1.0 wrapping.Closes #108.
Validation
Compatibility / review notes
Co-authored-by: Alessandro Giorgetti alessandro.giorgetti@live.com
Co-authored-by: Codex (OpenAI) codex@openai.com